[GitHub] [jena] afs commented on a change in pull request #1089: JENA-2181: Placeholder code for zst support

[GitBox <gi...@apache.org>]

afs commented on a change in pull request #1089:
URL: https://github.com/apache/jena/pull/1089#discussion_r734694236



##########
File path: jena-base/src/main/java/org/apache/jena/atlas/io/IO.java
##########
@@ -87,9 +90,10 @@ static public InputStream openFileEx(String filename) throws IOException, FileNo
         InputStream in = new FileInputStream(filename);
         String ext = getExtension(filename);
         switch ( ext ) {
-            case "":        return in;
+            case ext_none:  return in;
             case ext_gz:    return new GZIPInputStream(in);
             case ext_bz2:   return new BZip2CompressorInputStream(in);
+            //case ext_zst:   return new ZstdCompressorInputStream(in);

Review comment:
       I'd rather not until that has been tested. I left the placeholder code in as I'd done the setup work.
   
   Mentioning in the document means someone may well try and then we have an obligation.
   
   The situation with Fuseki is complicated because of repacking jars.
   
   Work on [a Kafka connector to Fuseki](https://github.com/Telicent-io/jena-fuseki-kafka) might get something done as Kafka seems to pull in ZStandard - I haven't investigated further.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org