You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Renjith Kamath <re...@gmail.com> on 2017/01/11 04:25:20 UTC
Review Request 55402: Minor: Ownership is changed before the creation
of directory
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55402/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty.
Bugs: AMBARI-19442
https://issues.apache.org/jira/browse/AMBARI-19442
Repository: ambari
Description
-------
call fails when dir is not preset
Diffs
-----
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py d3d494d
Diff: https://reviews.apache.org/r/55402/diff/
Testing
-------
manually tested on CentOS
Thanks,
Renjith Kamath
Re: Review Request 55402: Minor: Ownership is changed before the
creation of directory
Posted by Jayush Luniya <jl...@hortonworks.com>.
> On Jan. 12, 2017, 7:59 a.m., Attila Doroszlai wrote:
> > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py, line 129
> > <https://reviews.apache.org/r/55402/diff/1/?file=1602369#file1602369line129>
> >
> > Please adjust `ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py` accordingly, to avoid breaking unit tests.
> >
> > ```
> > Failed tests:
> > FAIL: test_configure_default (test_zeppelin_master.TestZeppelinMaster)
> > ----------------------------------------------------------------------
> > Traceback (most recent call last):
> > File "/Users/adoroszlai/src/ambari/ambari-common/src/test/python/mock/mock.py", line 1199, in patched
> > return func(*args, **keywargs)
> > File "/Users/adoroszlai/src/ambari/ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py", line 142, in test_configure_default
> > self.assert_configure_default()
> > File "/Users/adoroszlai/src/ambari/ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py", line 42, in assert_configure_default
> > self.assertResourceCalled('Execute', ('chown', '-R', u'zeppelin:zeppelin', '/var/run/zeppelin'), sudo = True)
> > File "/Users/adoroszlai/src/ambari/ambari-server/src/test/python/stacks/utils/RMFTestCase.py", line 280, in assertResourceCalled
> > self.assertEquals(resource_type, resource.__class__.__name__)
> > AssertionError: 'Execute' != 'Directory'
> >
> > FAIL: test_configure_secured (test_zeppelin_master.TestZeppelinMaster)
> > ----------------------------------------------------------------------
> > Traceback (most recent call last):
> > File "/Users/adoroszlai/src/ambari/ambari-common/src/test/python/mock/mock.py", line 1199, in patched
> > return func(*args, **keywargs)
> > File "/Users/adoroszlai/src/ambari/ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py", line 153, in test_configure_secured
> > self.assert_configure_secured()
> > File "/Users/adoroszlai/src/ambari/ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py", line 92, in assert_configure_secured
> > self.assertResourceCalled('Execute', ('chown', '-R', u'zeppelin:zeppelin', '/var/run/zeppelin'), sudo = True)
> > File "/Users/adoroszlai/src/ambari/ambari-server/src/test/python/stacks/utils/RMFTestCase.py", line 280, in assertResourceCalled
> > self.assertEquals(resource_type, resource.__class__.__name__)
> > AssertionError: 'Execute' != 'Directory'
> >
> > FAIL: test_start_default (test_zeppelin_master.TestZeppelinMaster)
> > ----------------------------------------------------------------------
> > Traceback (most recent call last):
> > File "/Users/adoroszlai/src/ambari/ambari-common/src/test/python/mock/mock.py", line 1199, in patched
> > return func(*args, **keywargs)
> > File "/Users/adoroszlai/src/ambari/ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py", line 319, in test_start_default
> > self.assert_configure_default()
> > File "/Users/adoroszlai/src/ambari/ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py", line 42, in assert_configure_default
> > self.assertResourceCalled('Execute', ('chown', '-R', u'zeppelin:zeppelin', '/var/run/zeppelin'), sudo = True)
> > File "/Users/adoroszlai/src/ambari/ambari-server/src/test/python/stacks/utils/RMFTestCase.py", line 280, in assertResourceCalled
> > self.assertEquals(resource_type, resource.__class__.__name__)
> > AssertionError: 'Execute' != 'Directory'
> >
> > FAIL: test_start_secured (test_zeppelin_master.TestZeppelinMaster)
> > ----------------------------------------------------------------------
> > Traceback (most recent call last):
> > File "/Users/adoroszlai/src/ambari/ambari-common/src/test/python/mock/mock.py", line 1199, in patched
> > return func(*args, **keywargs)
> > File "/Users/adoroszlai/src/ambari/ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py", line 331, in test_start_secured
> > self.assert_configure_secured()
> > File "/Users/adoroszlai/src/ambari/ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py", line 92, in assert_configure_secured
> > self.assertResourceCalled('Execute', ('chown', '-R', u'zeppelin:zeppelin', '/var/run/zeppelin'), sudo = True)
> > File "/Users/adoroszlai/src/ambari/ambari-server/src/test/python/stacks/utils/RMFTestCase.py", line 280, in assertResourceCalled
> > self.assertEquals(resource_type, resource.__class__.__name__)
> > AssertionError: 'Execute' != 'Directory'
> >
> > ----------------------------------------------------------------------
> > Total run:1158
> > Total errors:0
> > Total failures:4
> > ```
>
> Attila Doroszlai wrote:
> Sorry, I see that for `trunk` you have a separate patch in the JIRA that changes the test, too.
Please fix UTs in trunk and branch-2.5 if thats the case.
- Jayush
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55402/#review161357
-----------------------------------------------------------
On Jan. 11, 2017, 4:25 a.m., Renjith Kamath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55402/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2017, 4:25 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty.
>
>
> Bugs: AMBARI-19442
> https://issues.apache.org/jira/browse/AMBARI-19442
>
>
> Repository: ambari
>
>
> Description
> -------
>
> call fails when dir is not preset
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py d3d494d
>
> Diff: https://reviews.apache.org/r/55402/diff/
>
>
> Testing
> -------
>
> manually tested on CentOS
>
>
> Thanks,
>
> Renjith Kamath
>
>
Re: Review Request 55402: Minor: Ownership is changed before the
creation of directory
Posted by Attila Doroszlai <ad...@hortonworks.com>.
> On Jan. 12, 2017, 8:59 a.m., Attila Doroszlai wrote:
> > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py, line 129
> > <https://reviews.apache.org/r/55402/diff/1/?file=1602369#file1602369line129>
> >
> > Please adjust `ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py` accordingly, to avoid breaking unit tests.
> >
> > ```
> > Failed tests:
> > FAIL: test_configure_default (test_zeppelin_master.TestZeppelinMaster)
> > ----------------------------------------------------------------------
> > Traceback (most recent call last):
> > File "/Users/adoroszlai/src/ambari/ambari-common/src/test/python/mock/mock.py", line 1199, in patched
> > return func(*args, **keywargs)
> > File "/Users/adoroszlai/src/ambari/ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py", line 142, in test_configure_default
> > self.assert_configure_default()
> > File "/Users/adoroszlai/src/ambari/ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py", line 42, in assert_configure_default
> > self.assertResourceCalled('Execute', ('chown', '-R', u'zeppelin:zeppelin', '/var/run/zeppelin'), sudo = True)
> > File "/Users/adoroszlai/src/ambari/ambari-server/src/test/python/stacks/utils/RMFTestCase.py", line 280, in assertResourceCalled
> > self.assertEquals(resource_type, resource.__class__.__name__)
> > AssertionError: 'Execute' != 'Directory'
> >
> > FAIL: test_configure_secured (test_zeppelin_master.TestZeppelinMaster)
> > ----------------------------------------------------------------------
> > Traceback (most recent call last):
> > File "/Users/adoroszlai/src/ambari/ambari-common/src/test/python/mock/mock.py", line 1199, in patched
> > return func(*args, **keywargs)
> > File "/Users/adoroszlai/src/ambari/ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py", line 153, in test_configure_secured
> > self.assert_configure_secured()
> > File "/Users/adoroszlai/src/ambari/ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py", line 92, in assert_configure_secured
> > self.assertResourceCalled('Execute', ('chown', '-R', u'zeppelin:zeppelin', '/var/run/zeppelin'), sudo = True)
> > File "/Users/adoroszlai/src/ambari/ambari-server/src/test/python/stacks/utils/RMFTestCase.py", line 280, in assertResourceCalled
> > self.assertEquals(resource_type, resource.__class__.__name__)
> > AssertionError: 'Execute' != 'Directory'
> >
> > FAIL: test_start_default (test_zeppelin_master.TestZeppelinMaster)
> > ----------------------------------------------------------------------
> > Traceback (most recent call last):
> > File "/Users/adoroszlai/src/ambari/ambari-common/src/test/python/mock/mock.py", line 1199, in patched
> > return func(*args, **keywargs)
> > File "/Users/adoroszlai/src/ambari/ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py", line 319, in test_start_default
> > self.assert_configure_default()
> > File "/Users/adoroszlai/src/ambari/ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py", line 42, in assert_configure_default
> > self.assertResourceCalled('Execute', ('chown', '-R', u'zeppelin:zeppelin', '/var/run/zeppelin'), sudo = True)
> > File "/Users/adoroszlai/src/ambari/ambari-server/src/test/python/stacks/utils/RMFTestCase.py", line 280, in assertResourceCalled
> > self.assertEquals(resource_type, resource.__class__.__name__)
> > AssertionError: 'Execute' != 'Directory'
> >
> > FAIL: test_start_secured (test_zeppelin_master.TestZeppelinMaster)
> > ----------------------------------------------------------------------
> > Traceback (most recent call last):
> > File "/Users/adoroszlai/src/ambari/ambari-common/src/test/python/mock/mock.py", line 1199, in patched
> > return func(*args, **keywargs)
> > File "/Users/adoroszlai/src/ambari/ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py", line 331, in test_start_secured
> > self.assert_configure_secured()
> > File "/Users/adoroszlai/src/ambari/ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py", line 92, in assert_configure_secured
> > self.assertResourceCalled('Execute', ('chown', '-R', u'zeppelin:zeppelin', '/var/run/zeppelin'), sudo = True)
> > File "/Users/adoroszlai/src/ambari/ambari-server/src/test/python/stacks/utils/RMFTestCase.py", line 280, in assertResourceCalled
> > self.assertEquals(resource_type, resource.__class__.__name__)
> > AssertionError: 'Execute' != 'Directory'
> >
> > ----------------------------------------------------------------------
> > Total run:1158
> > Total errors:0
> > Total failures:4
> > ```
Sorry, I see that for `trunk` you have a separate patch in the JIRA that changes the test, too.
- Attila
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55402/#review161357
-----------------------------------------------------------
On Jan. 11, 2017, 5:25 a.m., Renjith Kamath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55402/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2017, 5:25 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty.
>
>
> Bugs: AMBARI-19442
> https://issues.apache.org/jira/browse/AMBARI-19442
>
>
> Repository: ambari
>
>
> Description
> -------
>
> call fails when dir is not preset
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py d3d494d
>
> Diff: https://reviews.apache.org/r/55402/diff/
>
>
> Testing
> -------
>
> manually tested on CentOS
>
>
> Thanks,
>
> Renjith Kamath
>
>
Re: Review Request 55402: Minor: Ownership is changed before the
creation of directory
Posted by Attila Doroszlai <ad...@hortonworks.com>.
> On Jan. 12, 2017, 8:59 a.m., Attila Doroszlai wrote:
> > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py, line 129
> > <https://reviews.apache.org/r/55402/diff/1/?file=1602369#file1602369line129>
> >
> > Please adjust `ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py` accordingly, to avoid breaking unit tests.
> >
> > ```
> > Failed tests:
> > FAIL: test_configure_default (test_zeppelin_master.TestZeppelinMaster)
> > ----------------------------------------------------------------------
> > Traceback (most recent call last):
> > File "/Users/adoroszlai/src/ambari/ambari-common/src/test/python/mock/mock.py", line 1199, in patched
> > return func(*args, **keywargs)
> > File "/Users/adoroszlai/src/ambari/ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py", line 142, in test_configure_default
> > self.assert_configure_default()
> > File "/Users/adoroszlai/src/ambari/ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py", line 42, in assert_configure_default
> > self.assertResourceCalled('Execute', ('chown', '-R', u'zeppelin:zeppelin', '/var/run/zeppelin'), sudo = True)
> > File "/Users/adoroszlai/src/ambari/ambari-server/src/test/python/stacks/utils/RMFTestCase.py", line 280, in assertResourceCalled
> > self.assertEquals(resource_type, resource.__class__.__name__)
> > AssertionError: 'Execute' != 'Directory'
> >
> > FAIL: test_configure_secured (test_zeppelin_master.TestZeppelinMaster)
> > ----------------------------------------------------------------------
> > Traceback (most recent call last):
> > File "/Users/adoroszlai/src/ambari/ambari-common/src/test/python/mock/mock.py", line 1199, in patched
> > return func(*args, **keywargs)
> > File "/Users/adoroszlai/src/ambari/ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py", line 153, in test_configure_secured
> > self.assert_configure_secured()
> > File "/Users/adoroszlai/src/ambari/ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py", line 92, in assert_configure_secured
> > self.assertResourceCalled('Execute', ('chown', '-R', u'zeppelin:zeppelin', '/var/run/zeppelin'), sudo = True)
> > File "/Users/adoroszlai/src/ambari/ambari-server/src/test/python/stacks/utils/RMFTestCase.py", line 280, in assertResourceCalled
> > self.assertEquals(resource_type, resource.__class__.__name__)
> > AssertionError: 'Execute' != 'Directory'
> >
> > FAIL: test_start_default (test_zeppelin_master.TestZeppelinMaster)
> > ----------------------------------------------------------------------
> > Traceback (most recent call last):
> > File "/Users/adoroszlai/src/ambari/ambari-common/src/test/python/mock/mock.py", line 1199, in patched
> > return func(*args, **keywargs)
> > File "/Users/adoroszlai/src/ambari/ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py", line 319, in test_start_default
> > self.assert_configure_default()
> > File "/Users/adoroszlai/src/ambari/ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py", line 42, in assert_configure_default
> > self.assertResourceCalled('Execute', ('chown', '-R', u'zeppelin:zeppelin', '/var/run/zeppelin'), sudo = True)
> > File "/Users/adoroszlai/src/ambari/ambari-server/src/test/python/stacks/utils/RMFTestCase.py", line 280, in assertResourceCalled
> > self.assertEquals(resource_type, resource.__class__.__name__)
> > AssertionError: 'Execute' != 'Directory'
> >
> > FAIL: test_start_secured (test_zeppelin_master.TestZeppelinMaster)
> > ----------------------------------------------------------------------
> > Traceback (most recent call last):
> > File "/Users/adoroszlai/src/ambari/ambari-common/src/test/python/mock/mock.py", line 1199, in patched
> > return func(*args, **keywargs)
> > File "/Users/adoroszlai/src/ambari/ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py", line 331, in test_start_secured
> > self.assert_configure_secured()
> > File "/Users/adoroszlai/src/ambari/ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py", line 92, in assert_configure_secured
> > self.assertResourceCalled('Execute', ('chown', '-R', u'zeppelin:zeppelin', '/var/run/zeppelin'), sudo = True)
> > File "/Users/adoroszlai/src/ambari/ambari-server/src/test/python/stacks/utils/RMFTestCase.py", line 280, in assertResourceCalled
> > self.assertEquals(resource_type, resource.__class__.__name__)
> > AssertionError: 'Execute' != 'Directory'
> >
> > ----------------------------------------------------------------------
> > Total run:1158
> > Total errors:0
> > Total failures:4
> > ```
>
> Attila Doroszlai wrote:
> Sorry, I see that for `trunk` you have a separate patch in the JIRA that changes the test, too.
>
> Jayush Luniya wrote:
> Please fix UTs in trunk and branch-2.5 if thats the case.
Clarification for my previous comment: the patch for trunk (in JIRA) passes the UT, and the UT is not present in branch-2.5. So all OK. Again, sorry for the noise.
- Attila
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55402/#review161357
-----------------------------------------------------------
On Jan. 11, 2017, 5:25 a.m., Renjith Kamath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55402/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2017, 5:25 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty.
>
>
> Bugs: AMBARI-19442
> https://issues.apache.org/jira/browse/AMBARI-19442
>
>
> Repository: ambari
>
>
> Description
> -------
>
> call fails when dir is not preset
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py d3d494d
>
> Diff: https://reviews.apache.org/r/55402/diff/
>
>
> Testing
> -------
>
> manually tested on CentOS
>
>
> Thanks,
>
> Renjith Kamath
>
>
Re: Review Request 55402: Minor: Ownership is changed before the
creation of directory
Posted by Attila Doroszlai <ad...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55402/#review161357
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py (line 128)
<https://reviews.apache.org/r/55402/#comment232599>
Please adjust `ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py` accordingly, to avoid breaking unit tests.
```
Failed tests:
FAIL: test_configure_default (test_zeppelin_master.TestZeppelinMaster)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/adoroszlai/src/ambari/ambari-common/src/test/python/mock/mock.py", line 1199, in patched
return func(*args, **keywargs)
File "/Users/adoroszlai/src/ambari/ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py", line 142, in test_configure_default
self.assert_configure_default()
File "/Users/adoroszlai/src/ambari/ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py", line 42, in assert_configure_default
self.assertResourceCalled('Execute', ('chown', '-R', u'zeppelin:zeppelin', '/var/run/zeppelin'), sudo = True)
File "/Users/adoroszlai/src/ambari/ambari-server/src/test/python/stacks/utils/RMFTestCase.py", line 280, in assertResourceCalled
self.assertEquals(resource_type, resource.__class__.__name__)
AssertionError: 'Execute' != 'Directory'
FAIL: test_configure_secured (test_zeppelin_master.TestZeppelinMaster)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/adoroszlai/src/ambari/ambari-common/src/test/python/mock/mock.py", line 1199, in patched
return func(*args, **keywargs)
File "/Users/adoroszlai/src/ambari/ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py", line 153, in test_configure_secured
self.assert_configure_secured()
File "/Users/adoroszlai/src/ambari/ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py", line 92, in assert_configure_secured
self.assertResourceCalled('Execute', ('chown', '-R', u'zeppelin:zeppelin', '/var/run/zeppelin'), sudo = True)
File "/Users/adoroszlai/src/ambari/ambari-server/src/test/python/stacks/utils/RMFTestCase.py", line 280, in assertResourceCalled
self.assertEquals(resource_type, resource.__class__.__name__)
AssertionError: 'Execute' != 'Directory'
FAIL: test_start_default (test_zeppelin_master.TestZeppelinMaster)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/adoroszlai/src/ambari/ambari-common/src/test/python/mock/mock.py", line 1199, in patched
return func(*args, **keywargs)
File "/Users/adoroszlai/src/ambari/ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py", line 319, in test_start_default
self.assert_configure_default()
File "/Users/adoroszlai/src/ambari/ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py", line 42, in assert_configure_default
self.assertResourceCalled('Execute', ('chown', '-R', u'zeppelin:zeppelin', '/var/run/zeppelin'), sudo = True)
File "/Users/adoroszlai/src/ambari/ambari-server/src/test/python/stacks/utils/RMFTestCase.py", line 280, in assertResourceCalled
self.assertEquals(resource_type, resource.__class__.__name__)
AssertionError: 'Execute' != 'Directory'
FAIL: test_start_secured (test_zeppelin_master.TestZeppelinMaster)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/adoroszlai/src/ambari/ambari-common/src/test/python/mock/mock.py", line 1199, in patched
return func(*args, **keywargs)
File "/Users/adoroszlai/src/ambari/ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py", line 331, in test_start_secured
self.assert_configure_secured()
File "/Users/adoroszlai/src/ambari/ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py", line 92, in assert_configure_secured
self.assertResourceCalled('Execute', ('chown', '-R', u'zeppelin:zeppelin', '/var/run/zeppelin'), sudo = True)
File "/Users/adoroszlai/src/ambari/ambari-server/src/test/python/stacks/utils/RMFTestCase.py", line 280, in assertResourceCalled
self.assertEquals(resource_type, resource.__class__.__name__)
AssertionError: 'Execute' != 'Directory'
----------------------------------------------------------------------
Total run:1158
Total errors:0
Total failures:4
```
- Attila Doroszlai
On Jan. 11, 2017, 5:25 a.m., Renjith Kamath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55402/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2017, 5:25 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty.
>
>
> Bugs: AMBARI-19442
> https://issues.apache.org/jira/browse/AMBARI-19442
>
>
> Repository: ambari
>
>
> Description
> -------
>
> call fails when dir is not preset
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py d3d494d
>
> Diff: https://reviews.apache.org/r/55402/diff/
>
>
> Testing
> -------
>
> manually tested on CentOS
>
>
> Thanks,
>
> Renjith Kamath
>
>
Re: Review Request 55402: Minor: Ownership is changed before the
creation of directory
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55402/#review161282
-----------------------------------------------------------
Ship it!
Ship It!
- Jayush Luniya
On Jan. 11, 2017, 4:25 a.m., Renjith Kamath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55402/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2017, 4:25 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty.
>
>
> Bugs: AMBARI-19442
> https://issues.apache.org/jira/browse/AMBARI-19442
>
>
> Repository: ambari
>
>
> Description
> -------
>
> call fails when dir is not preset
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py d3d494d
>
> Diff: https://reviews.apache.org/r/55402/diff/
>
>
> Testing
> -------
>
> manually tested on CentOS
>
>
> Thanks,
>
> Renjith Kamath
>
>
Re: Review Request 55402: Minor: Ownership is changed before the
creation of directory
Posted by Rohit Choudhary <rc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55402/#review161393
-----------------------------------------------------------
Ship it!
Ship It!
- Rohit Choudhary
On Jan. 11, 2017, 4:25 a.m., Renjith Kamath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55402/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2017, 4:25 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty.
>
>
> Bugs: AMBARI-19442
> https://issues.apache.org/jira/browse/AMBARI-19442
>
>
> Repository: ambari
>
>
> Description
> -------
>
> call fails when dir is not preset
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py d3d494d
>
> Diff: https://reviews.apache.org/r/55402/diff/
>
>
> Testing
> -------
>
> manually tested on CentOS
>
>
> Thanks,
>
> Renjith Kamath
>
>