[GitHub] [arrow] icexelloss commented on a diff in pull request #34392: GH-34391: [C++] Future as-of-join-node hangs on distant times

["icexelloss (via GitHub)" <gi...@apache.org>]

icexelloss commented on code in PR #34392:
URL: https://github.com/apache/arrow/pull/34392#discussion_r1195365391


##########
cpp/src/arrow/acero/asof_join_node.cc:
##########
@@ -370,13 +496,18 @@ class KeyHasher {
         column_arrays_[k] =
             ColumnArrayFromArrayDataAndMetadata(array_data, metadata_[k], i, length);
       }
+      // write directly to the cache
       Hashing64::HashMultiColumn(column_arrays_, &ctx_, hashes_.data() + i);
     }
-    batch_ = batch;
+    DEBUG_SYNC(*node_, "key hasher ", index_, " got hashes ",
+               compute::internal::GenericToString(hashes_), DEBUG_MANIP(std::endl));
+    batch_ = batch;  // associate cache with current batch
     return hashes_;
   }
 
  private:
+  AsofJoinNode* node_ = nullptr;  // avoids circular dependency during initialization

Review Comment:
   Are `node_` and `index_` for debug purpose only?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org