You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Scott Banachowski (JIRA)" <ji...@apache.org> on 2009/09/08 23:10:59 UTC
[jira] Created: (AVRO-113) C++ version is using wrong endian for
varints
C++ version is using wrong endian for varints
---------------------------------------------
Key: AVRO-113
URL: https://issues.apache.org/jira/browse/AVRO-113
Project: Avro
Issue Type: Bug
Components: c++
Reporter: Scott Banachowski
I totally overlooked the wording in the spec that says least significant parts appear before more significant ones, and used the inverse convention.
This was discovered when I compared to Java output (highlighting the absence of the interoperability tests for c++!).
Here is a fix for the code. Interoperability tests should follow soon.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-113) C++ version is using wrong endian for
varints
Posted by "Scott Banachowski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Scott Banachowski updated AVRO-113:
-----------------------------------
Attachment: AVRO-113.patch
> C++ version is using wrong endian for varints
> ---------------------------------------------
>
> Key: AVRO-113
> URL: https://issues.apache.org/jira/browse/AVRO-113
> Project: Avro
> Issue Type: Bug
> Components: c++
> Reporter: Scott Banachowski
> Attachments: AVRO-113.patch
>
>
> I totally overlooked the wording in the spec that says least significant parts appear before more significant ones, and used the inverse convention.
> This was discovered when I compared to Java output (highlighting the absence of the interoperability tests for c++!).
> Here is a fix for the code. Interoperability tests should follow soon.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-113) C++ version is using wrong endian for
varints
Posted by "Scott Banachowski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Scott Banachowski updated AVRO-113:
-----------------------------------
Status: Patch Available (was: Open)
> C++ version is using wrong endian for varints
> ---------------------------------------------
>
> Key: AVRO-113
> URL: https://issues.apache.org/jira/browse/AVRO-113
> Project: Avro
> Issue Type: Bug
> Components: c++
> Reporter: Scott Banachowski
> Attachments: AVRO-113.patch
>
>
> I totally overlooked the wording in the spec that says least significant parts appear before more significant ones, and used the inverse convention.
> This was discovered when I compared to Java output (highlighting the absence of the interoperability tests for c++!).
> Here is a fix for the code. Interoperability tests should follow soon.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-113) C++ version is using wrong endian for
varints
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Cutting updated AVRO-113:
------------------------------
Resolution: Fixed
Fix Version/s: 1.2.0
Status: Resolved (was: Patch Available)
I just committed this. Thanks, Scott!
> C++ version is using wrong endian for varints
> ---------------------------------------------
>
> Key: AVRO-113
> URL: https://issues.apache.org/jira/browse/AVRO-113
> Project: Avro
> Issue Type: Bug
> Components: c++
> Reporter: Scott Banachowski
> Assignee: Scott Banachowski
> Fix For: 1.2.0
>
> Attachments: AVRO-113.patch
>
>
> I totally overlooked the wording in the spec that says least significant parts appear before more significant ones, and used the inverse convention.
> This was discovered when I compared to Java output (highlighting the absence of the interoperability tests for c++!).
> Here is a fix for the code. Interoperability tests should follow soon.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.