You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by kr...@apache.org on 2017/01/06 21:47:39 UTC

[19/25] lucene-solr:jira/solr-8593: SOLR-9928: MetricsDirectoryFactory::renameWithOverwrite incorrectly calls super (Mike Drob via ab)

SOLR-9928: MetricsDirectoryFactory::renameWithOverwrite incorrectly calls super (Mike Drob via ab)


Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/e5264c48
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/e5264c48
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/e5264c48

Branch: refs/heads/jira/solr-8593
Commit: e5264c48955165ac5c5b1aabba4748378d3f6fa9
Parents: e5d2884
Author: Andrzej Bialecki <ab...@apache.org>
Authored: Thu Jan 5 17:46:14 2017 +0100
Committer: Andrzej Bialecki <ab...@apache.org>
Committed: Thu Jan 5 17:46:14 2017 +0100

----------------------------------------------------------------------
 .../src/java/org/apache/solr/core/MetricsDirectoryFactory.java | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/e5264c48/solr/core/src/java/org/apache/solr/core/MetricsDirectoryFactory.java
----------------------------------------------------------------------
diff --git a/solr/core/src/java/org/apache/solr/core/MetricsDirectoryFactory.java b/solr/core/src/java/org/apache/solr/core/MetricsDirectoryFactory.java
index 62e82ac..8706c61 100644
--- a/solr/core/src/java/org/apache/solr/core/MetricsDirectoryFactory.java
+++ b/solr/core/src/java/org/apache/solr/core/MetricsDirectoryFactory.java
@@ -198,7 +198,11 @@ public class MetricsDirectoryFactory extends DirectoryFactory implements SolrCor
 
   @Override
   public void renameWithOverwrite(Directory dir, String fileName, String toName) throws IOException {
-    super.renameWithOverwrite(dir, fileName, toName);
+    if (dir instanceof MetricsDirectory) {
+      dir = ((MetricsDirectory) dir).getDelegate();
+    }
+
+    in.renameWithOverwrite(dir, fileName, toName);
   }
 
   @Override