[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #5865: Provide ability to fetch Traffic Vault secret key from HashiCorp Vault

[GitBox <gi...@apache.org>]

mattjackson220 commented on a change in pull request #5865:
URL: https://github.com/apache/trafficcontrol/pull/5865#discussion_r635435835



##########
File path: traffic_ops/traffic_ops_golang/trafficvault/backends/postgres/postgres.go
##########
@@ -482,8 +505,22 @@ func validateConfig(cfg Config) error {
 		"port":                  validation.Validate(cfg.Port, validation.By(tovalidate.IsValidPortNumber)),
 		"max_connections":       validation.Validate(cfg.MaxConnections, validation.Min(0)),
 		"query_timeout_seconds": validation.Validate(cfg.QueryTimeoutSeconds, validation.Min(0)),
-		"aes_key_location":      validation.Validate(cfg.AesKeyLocation, validation.Required),
 	})
+	aesKeyLocSet := cfg.AesKeyLocation != ""
+	hashiCorpVaultSet := cfg.HashiCorpVault != nil

Review comment:
       maybe add something like this `&& *cfg.HashiCorpVault != HashiCorpVault{}` so people can leave an empty field in the cdn.conf? not important to me if you think thats not worth doing, just an idea cause i tried testing it that way




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org