You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@weex.apache.org by lycool <gi...@git.apache.org> on 2017/04/07 06:36:43 UTC
[GitHub] incubator-weex pull request #232: replace Java WxTimerModule with C++ setTim...
GitHub user lycool opened a pull request:
https://github.com/apache/incubator-weex/pull/232
replace Java WxTimerModule with C++ setTimeout/setInterval implementa\u2026
replace Java WxTimerModule with C++ setTimeout/setInterval implementation.
clear all unhandled setTimeout/setInterval timers after Weex instance is destroyed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lycool/incubator-weex 0.12-dev
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/232.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #232
----
commit 1ce2a638f887feeca2f5f5f8c89784e770f162fe
Author: kaifeng.ly <ka...@alibaba-inc.com>
Date: 2017-04-07T06:34:32Z
replace Java WxTimerModule with C++ setTimeout/setInterval implementation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #232: replace Java WxTimerModule with C++ setTim...
Posted by lycool <gi...@git.apache.org>.
Github user lycool commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/232#discussion_r110843916
--- Diff: android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java ---
@@ -1069,7 +1072,10 @@ public void invokeExecJS(String instanceId, String namespace, String function,
.append("function:").append(function);
if(logTaskDetail)
mLodBuilder.append(" tasks:").append(WXJsonUtils.fromObjectToJSONString(args));
- WXLogUtils.d(mLodBuilder.substring(0));
+
+ //WXLogUtils.d(mLodBuilder.substring(0));
--- End diff --
WXLogUtils.d removed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #232: replace Java WxTimerModule with C++ setTim...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-weex/pull/232
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #232: replace Java WxTimerModule with C++ setTim...
Posted by lycool <gi...@git.apache.org>.
Github user lycool commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/232#discussion_r110843949
--- Diff: android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java ---
@@ -570,7 +570,10 @@ public int callNative(String instanceId, String tasks, String callback) {
if (WXEnvironment.isApkDebugable()) {
mLodBuilder.append("[WXBridgeManager] callNative >>>> instanceId:").append(instanceId)
.append(", tasks:").append(tasks).append(", callback:").append(callback);
- WXLogUtils.d(mLodBuilder.substring(0));
+
+ //WXLogUtils.d(mLodBuilder.substring(0));
--- End diff --
WXLogUtils.d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #232: replace Java WxTimerModule with C++ setTim...
Posted by lycool <gi...@git.apache.org>.
Github user lycool commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/232#discussion_r110843986
--- Diff: android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java ---
@@ -570,7 +570,10 @@ public int callNative(String instanceId, String tasks, String callback) {
if (WXEnvironment.isApkDebugable()) {
mLodBuilder.append("[WXBridgeManager] callNative >>>> instanceId:").append(instanceId)
.append(", tasks:").append(tasks).append(", callback:").append(callback);
- WXLogUtils.d(mLodBuilder.substring(0));
+
+ //WXLogUtils.d(mLodBuilder.substring(0));
--- End diff --
WXLogUtils.d removed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #232: replace Java WxTimerModule with C++ setTim...
Posted by sospartan <gi...@git.apache.org>.
Github user sospartan commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/232#discussion_r110834606
--- Diff: android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java ---
@@ -1069,7 +1072,10 @@ public void invokeExecJS(String instanceId, String namespace, String function,
.append("function:").append(function);
if(logTaskDetail)
mLodBuilder.append(" tasks:").append(WXJsonUtils.fromObjectToJSONString(args));
- WXLogUtils.d(mLodBuilder.substring(0));
+
+ //WXLogUtils.d(mLodBuilder.substring(0));
--- End diff --
Just remove it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #232: replace Java WxTimerModule with C++ setTimeout/se...
Posted by lycool <gi...@git.apache.org>.
Github user lycool commented on the issue:
https://github.com/apache/incubator-weex/pull/232
WXLogUtils.d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #232: replace Java WxTimerModule with C++ setTim...
Posted by sospartan <gi...@git.apache.org>.
Github user sospartan commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/232#discussion_r110834586
--- Diff: android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java ---
@@ -570,7 +570,10 @@ public int callNative(String instanceId, String tasks, String callback) {
if (WXEnvironment.isApkDebugable()) {
mLodBuilder.append("[WXBridgeManager] callNative >>>> instanceId:").append(instanceId)
.append(", tasks:").append(tasks).append(", callback:").append(callback);
- WXLogUtils.d(mLodBuilder.substring(0));
+
+ //WXLogUtils.d(mLodBuilder.substring(0));
--- End diff --
Just remove it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---