You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2012/11/09 21:23:13 UTC
[Bug 54127] New: WsOutbound is missing a ping method
https://issues.apache.org/bugzilla/show_bug.cgi?id=54127
Priority: P2
Bug ID: 54127
Assignee: dev@tomcat.apache.org
Summary: WsOutbound is missing a ping method
Severity: enhancement
Classification: Unclassified
Reporter: sean.winterberger@gmail.com
Hardware: PC
Status: NEW
Version: 7.0.32
Component: Catalina
Product: Tomcat 7
Created attachment 29577
--> https://issues.apache.org/bugzilla/attachment.cgi?id=29577&action=edit
patch which adds ping functionality to WsOutbound
WsOutbound currently lacks the ability to send a ping request to the client.
Attached patch creates a new method pong which takes in a ByteBuffer and passes
the ping byte (0x09) to sendControlMessage which sets the opcode byte on the
frame. Refactored pong method to all call sendControlMessage as opposed to
duplicate code.
Added websocket.Constants import for OPCODE_PING/PONG.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 54127] WsOutbound is missing a ping method
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54127
Mark Thomas <ma...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
OS| |All
--- Comment #2 from Mark Thomas <ma...@apache.org> ---
Many thanks for the patch. I had to clean it up a little:
- tabs -> 4 spaces
- remove trailing white space
- remove unnecessary (and in wrong order) import
Running the build with Checkstyle enabled would have caught all of the above.
That said, they were trivial to fix.
The patch has been applied to trunk and 7.0.x and will be include in 7.0.33
onwards. Thanks again.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 54127] WsOutbound is missing a ping method
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54127
Mark Thomas <ma...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #29577|0 |1
is patch| |
Attachment #29577|application/octet-stream |text/plain
mime type| |
--- Comment #1 from Mark Thomas <ma...@apache.org> ---
Comment on attachment 29577
--> https://issues.apache.org/bugzilla/attachment.cgi?id=29577
patch which adds ping functionality to WsOutbound
Fix MIME type. Set patch flag.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org