You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/26 05:31:47 UTC

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #31962: [SPARK-34869][K8S][TEST] Extend "EXTRA LOGS FOR THE FAILED TEST" section of k8s integration test log with the describe pods output

dongjoon-hyun commented on a change in pull request #31962:
URL: https://github.com/apache/spark/pull/31962#discussion_r602026102



##########
File path: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/backend/minikube/Minikube.scala
##########
@@ -126,17 +126,21 @@ private[spark] object Minikube extends Logging {
     }
   }
 
-  def executeMinikube(action: String, args: String*): Seq[String] = {
+  def describePods(labels: String): Seq[String] =
+    Minikube.executeMinikube(false, "kubectl", "--", "describe", "pods", "--all-namespaces",
+      "-l", labels)

Review comment:
       If you don't mind, could you move this function to the end? For example, after `minikubeServiceAction`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org