You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/01/30 00:14:13 UTC
[GitHub] [incubator-pinot] chenboat opened a new pull request #5026: Remove
the use of hardcoded localhost name in the server starter integration test.
chenboat opened a new pull request #5026: Remove the use of hardcoded localhost name in the server starter integration test.
URL: https://github.com/apache/incubator-pinot/pull/5026
The current test assign the test machine always uses "localhost" as hostname. This may not be true in many setting. Here we instead use the Netty lib to discover the hostname.
@jackjlli
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] jackjlli commented on issue #5026: Remove the use
of hardcoded localhost name in the server starter integration test.
Posted by GitBox <gi...@apache.org>.
jackjlli commented on issue #5026: Remove the use of hardcoded localhost name in the server starter integration test.
URL: https://github.com/apache/incubator-pinot/pull/5026#issuecomment-580378900
Closing this PR since there's another PR merged into master already.
https://github.com/apache/incubator-pinot/pull/5029
@chenboat Thanks for the help!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] jackjlli closed pull request #5026: Remove the
use of hardcoded localhost name in the server starter integration test.
Posted by GitBox <gi...@apache.org>.
jackjlli closed pull request #5026: Remove the use of hardcoded localhost name in the server starter integration test.
URL: https://github.com/apache/incubator-pinot/pull/5026
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org