You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/13 07:41:23 UTC

[GitHub] [flink] HuangXingBo opened a new pull request #14627: [FLINK-20946][python] Optimize Python ValueState Implementation In PyFlink

HuangXingBo opened a new pull request #14627:
URL: https://github.com/apache/flink/pull/14627


   ## What is the purpose of the change
   
   *This pull request will Optimize Python ValueState Implementation In PyFlink*
   
   
   ## Brief change log
   
     - *Optimize Python ValueState Implementation In PyFlink*
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
     - *Original Tests*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14627: [FLINK-20946][python] Optimize Python ValueState Implementation In PyFlink

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14627:
URL: https://github.com/apache/flink/pull/14627#issuecomment-759272918


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a0e6a39605a3d1a80f75f8764534dfb82d08c31f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11971",
       "triggerID" : "a0e6a39605a3d1a80f75f8764534dfb82d08c31f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ff00387c962b937a5dabaaeb9241acfdbc9e49ab",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12032",
       "triggerID" : "ff00387c962b937a5dabaaeb9241acfdbc9e49ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "293b8ca01400d911925460a29cc8d2bfb41a8522",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12093",
       "triggerID" : "293b8ca01400d911925460a29cc8d2bfb41a8522",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ff00387c962b937a5dabaaeb9241acfdbc9e49ab Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12032) 
   * 293b8ca01400d911925460a29cc8d2bfb41a8522 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12093) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14627: [FLINK-20946][python] Optimize Python ValueState Implementation In PyFlink

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14627:
URL: https://github.com/apache/flink/pull/14627#issuecomment-759272918


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a0e6a39605a3d1a80f75f8764534dfb82d08c31f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a0e6a39605a3d1a80f75f8764534dfb82d08c31f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a0e6a39605a3d1a80f75f8764534dfb82d08c31f UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] WeiZhong94 commented on pull request #14627: [FLINK-20946][python] Optimize Python ValueState Implementation In PyFlink

Posted by GitBox <gi...@apache.org>.
WeiZhong94 commented on pull request #14627:
URL: https://github.com/apache/flink/pull/14627#issuecomment-759898742


   @HuangXingBo Thanks for your PR! 
   
   I think we can do better in this PR, e.g. improve the logic of SynchronousValueRuntimeState. Now the update operation of SynchronousValueRuntimeState will cause 2 network requests, we can optimize it to 1.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14627: [FLINK-20946][python] Optimize Python ValueState Implementation In PyFlink

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14627:
URL: https://github.com/apache/flink/pull/14627#issuecomment-759272918


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a0e6a39605a3d1a80f75f8764534dfb82d08c31f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11971",
       "triggerID" : "a0e6a39605a3d1a80f75f8764534dfb82d08c31f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ff00387c962b937a5dabaaeb9241acfdbc9e49ab",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12032",
       "triggerID" : "ff00387c962b937a5dabaaeb9241acfdbc9e49ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "293b8ca01400d911925460a29cc8d2bfb41a8522",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "293b8ca01400d911925460a29cc8d2bfb41a8522",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ff00387c962b937a5dabaaeb9241acfdbc9e49ab Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12032) 
   * 293b8ca01400d911925460a29cc8d2bfb41a8522 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14627: [FLINK-20946][python] Optimize Python ValueState Implementation In PyFlink

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14627:
URL: https://github.com/apache/flink/pull/14627#issuecomment-759272918


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a0e6a39605a3d1a80f75f8764534dfb82d08c31f",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11971",
       "triggerID" : "a0e6a39605a3d1a80f75f8764534dfb82d08c31f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ff00387c962b937a5dabaaeb9241acfdbc9e49ab",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12032",
       "triggerID" : "ff00387c962b937a5dabaaeb9241acfdbc9e49ab",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a0e6a39605a3d1a80f75f8764534dfb82d08c31f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11971) 
   * ff00387c962b937a5dabaaeb9241acfdbc9e49ab Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12032) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14627: [FLINK-20946][python] Optimize Python ValueState Implementation In PyFlink

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14627:
URL: https://github.com/apache/flink/pull/14627#issuecomment-759268470


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit a0e6a39605a3d1a80f75f8764534dfb82d08c31f (Wed Jan 13 07:44:31 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-20946).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] dianfu closed pull request #14627: [FLINK-20946][python] Optimize Python ValueState Implementation In PyFlink

Posted by GitBox <gi...@apache.org>.
dianfu closed pull request #14627:
URL: https://github.com/apache/flink/pull/14627


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14627: [FLINK-20946][python] Optimize Python ValueState Implementation In PyFlink

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14627:
URL: https://github.com/apache/flink/pull/14627#issuecomment-759272918


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a0e6a39605a3d1a80f75f8764534dfb82d08c31f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11971",
       "triggerID" : "a0e6a39605a3d1a80f75f8764534dfb82d08c31f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ff00387c962b937a5dabaaeb9241acfdbc9e49ab",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12032",
       "triggerID" : "ff00387c962b937a5dabaaeb9241acfdbc9e49ab",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ff00387c962b937a5dabaaeb9241acfdbc9e49ab Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12032) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14627: [FLINK-20946][python] Optimize Python ValueState Implementation In PyFlink

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14627:
URL: https://github.com/apache/flink/pull/14627#issuecomment-759272918


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a0e6a39605a3d1a80f75f8764534dfb82d08c31f",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11971",
       "triggerID" : "a0e6a39605a3d1a80f75f8764534dfb82d08c31f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a0e6a39605a3d1a80f75f8764534dfb82d08c31f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11971) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14627: [FLINK-20946][python] Optimize Python ValueState Implementation In PyFlink

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14627:
URL: https://github.com/apache/flink/pull/14627#issuecomment-759272918


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a0e6a39605a3d1a80f75f8764534dfb82d08c31f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11971",
       "triggerID" : "a0e6a39605a3d1a80f75f8764534dfb82d08c31f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ff00387c962b937a5dabaaeb9241acfdbc9e49ab",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12032",
       "triggerID" : "ff00387c962b937a5dabaaeb9241acfdbc9e49ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "293b8ca01400d911925460a29cc8d2bfb41a8522",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12093",
       "triggerID" : "293b8ca01400d911925460a29cc8d2bfb41a8522",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 293b8ca01400d911925460a29cc8d2bfb41a8522 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12093) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14627: [FLINK-20946][python] Optimize Python ValueState Implementation In PyFlink

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14627:
URL: https://github.com/apache/flink/pull/14627#issuecomment-759272918


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a0e6a39605a3d1a80f75f8764534dfb82d08c31f",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11971",
       "triggerID" : "a0e6a39605a3d1a80f75f8764534dfb82d08c31f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a0e6a39605a3d1a80f75f8764534dfb82d08c31f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11971) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] HuangXingBo commented on pull request #14627: [FLINK-20946][python] Optimize Python ValueState Implementation In PyFlink

Posted by GitBox <gi...@apache.org>.
HuangXingBo commented on pull request #14627:
URL: https://github.com/apache/flink/pull/14627#issuecomment-759982957


   @WeiZhong94 Thanks a lot for the suggestion. I have updated the PR at the latest commit.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14627: [FLINK-20946][python] Optimize Python ValueState Implementation In PyFlink

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14627:
URL: https://github.com/apache/flink/pull/14627#issuecomment-759272918


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a0e6a39605a3d1a80f75f8764534dfb82d08c31f",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11971",
       "triggerID" : "a0e6a39605a3d1a80f75f8764534dfb82d08c31f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ff00387c962b937a5dabaaeb9241acfdbc9e49ab",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ff00387c962b937a5dabaaeb9241acfdbc9e49ab",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a0e6a39605a3d1a80f75f8764534dfb82d08c31f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11971) 
   * ff00387c962b937a5dabaaeb9241acfdbc9e49ab UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14627: [FLINK-20946][python] Optimize Python ValueState Implementation In PyFlink

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14627:
URL: https://github.com/apache/flink/pull/14627#issuecomment-759268470


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 293b8ca01400d911925460a29cc8d2bfb41a8522 (Fri May 28 07:11:14 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-20946).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org