[GitHub] [incubator-nuttx-apps] Ouss4 commented on a change in pull request #358: Remove the unnecessary touch and delete from Makefile

[GitBox <gi...@apache.org>]

Ouss4 commented on a change in pull request #358:
URL: https://github.com/apache/incubator-nuttx-apps/pull/358#discussion_r468141280



##########
File path: graphics/lvgl/Makefile
##########
@@ -74,13 +74,9 @@ $(LVGL_UNPACKNAME): $(LVGL_TARBALL)
 	@echo "Unpacking: $(LVGL_TARBALL) -> $(LVGL_UNPACKNAME)"
 	$(Q) $(UNPACK) $(LVGL_TARBALL)
 	$(Q) mv	lvgl-$(LVGL_VERSION) $(LVGL_UNPACKNAME)
-	$(Q) touch $(LVGL_UNPACKNAME)

Review comment:
       @xiaoxiang781216 I think touch is still necessary here.
   I was puzzled by this one, and thought it was unnecessary, please confirm the following:
   1. We extract the folder, say LVGL-v2.2.0 (this folder will keep the timestamps when it was tar'ed)
   2. We rename it as LVGL (it also keeps the timestamps of the above)
   
   With that, the tarball is newer than the folder LVGL and the target will execute again with the next `make` and copy an extra LVGL-v2.2.0 inside LVGL.  Now LVGL has changed and no more copies.
   
   With `touch` we update the folder's timestamps and we won't have an extra copy.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org