You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/02/01 00:19:35 UTC
[GitHub] [solr] janhoy opened a new pull request #582: SOLR-15966 Get rid of WEB-INF/lib/jsr305-3.0.2.jar
janhoy opened a new pull request #582:
URL: https://github.com/apache/solr/pull/582
https://issues.apache.org/jira/browse/SOLR-15966
WIP attempt of excluding jsr305 and javax.annotations jars from the release.
I did a full `gradlew check` on this branch, and it succeeded, so I think it does no harm simply excluding these?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy edited a comment on pull request #582: SOLR-15966 Get rid of WEB-INF/lib/jsr305-3.0.2.jar
Posted by GitBox <gi...@apache.org>.
janhoy edited a comment on pull request #582:
URL: https://github.com/apache/solr/pull/582#issuecomment-1026858710
I think we got rid of it now from the distro. Proof:
Main branch:
```bash
gw dev
find solr/packaging/build/dev | grep -E "jsr305|javax.annotation-api"
solr/packaging/build/dev/licenses/jsr305-NOTICE.txt
solr/packaging/build/dev/licenses/jsr305-3.0.2.jar.sha1
solr/packaging/build/dev/licenses/javax.annotation-api-LICENSE-CDDL.txt
solr/packaging/build/dev/licenses/javax.annotation-api-1.3.2.jar.sha1
solr/packaging/build/dev/licenses/jsr305-LICENSE-ASL.txt
solr/packaging/build/dev/server/solr-webapp/webapp/WEB-INF/lib/jsr305-3.0.2.jar
solr/packaging/build/dev/modules/gcs-repository/lib/javax.annotation-api-1.3.2.jar
```
This PR branch:
```bash
gw dev
find solr/packaging/build/dev | grep -E "jsr305|javax.annotation-api"
# nothing
```
Should these be "more global" in some way? Now each module will need to exclude.
But if no more improvements are suggested I'll merge this soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy merged pull request #582: SOLR-15966 Get rid of WEB-INF/lib/jsr305-3.0.2.jar
Posted by GitBox <gi...@apache.org>.
janhoy merged pull request #582:
URL: https://github.com/apache/solr/pull/582
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #582: SOLR-15966 Get rid of WEB-INF/lib/jsr305-3.0.2.jar
Posted by GitBox <gi...@apache.org>.
janhoy commented on pull request #582:
URL: https://github.com/apache/solr/pull/582#issuecomment-1026858710
I think we got rid of it now from the distro
```
gw dev
find solr/packaging/build/dev | grep -E "jsr305|javax.annotation-api"
# (nothing)
```
Should these be "more global" in some way? Now each module will need to exclude.
But if no more improvements are suggested I'll merge this soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob commented on a change in pull request #582: SOLR-15966 Get rid of WEB-INF/lib/jsr305-3.0.2.jar
Posted by GitBox <gi...@apache.org>.
madrob commented on a change in pull request #582:
URL: https://github.com/apache/solr/pull/582#discussion_r796202923
##########
File path: solr/modules/gcs-repository/build.gradle
##########
@@ -51,6 +56,7 @@ dependencies {
implementation('io.opencensus:opencensus-api') { transitive = false }
implementation('io.opencensus:opencensus-contrib-http-util') { exclude group: 'com.google.guava', module: 'guava' }
+ testImplementation('com.google.code.findbugs:jsr305') { transitive = false }
Review comment:
I tried removing this and everything still seemed to work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley commented on a change in pull request #582: SOLR-15966 Get rid of WEB-INF/lib/jsr305-3.0.2.jar
Posted by GitBox <gi...@apache.org>.
dsmiley commented on a change in pull request #582:
URL: https://github.com/apache/solr/pull/582#discussion_r796219783
##########
File path: versions.lock
##########
@@ -29,7 +29,7 @@ com.google.cloud:google-cloud-core:1.94.3 (3 constraints: da2307c0)
com.google.cloud:google-cloud-core-http:1.94.3 (2 constraints: 651543d8)
com.google.cloud:google-cloud-storage:1.113.14 (2 constraints: 10143aa3)
com.google.code.findbugs:annotations:3.0.1 (1 constraints: 0605fb35)
-com.google.code.findbugs:jsr305:3.0.2 (9 constraints: 057f5545)
+com.google.code.findbugs:jsr305:3.0.2 (2 constraints: cd195721)
Review comment:
What are the remaining 2 references?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on a change in pull request #582: SOLR-15966 Get rid of WEB-INF/lib/jsr305-3.0.2.jar
Posted by GitBox <gi...@apache.org>.
janhoy commented on a change in pull request #582:
URL: https://github.com/apache/solr/pull/582#discussion_r796365722
##########
File path: solr/modules/gcs-repository/build.gradle
##########
@@ -51,6 +56,7 @@ dependencies {
implementation('io.opencensus:opencensus-api') { transitive = false }
implementation('io.opencensus:opencensus-contrib-http-util') { exclude group: 'com.google.guava', module: 'guava' }
+ testImplementation('com.google.code.findbugs:jsr305') { transitive = false }
Review comment:
I moved this from "implementation" to "testImplementation". But if it is not needed, then fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on a change in pull request #582: SOLR-15966 Get rid of WEB-INF/lib/jsr305-3.0.2.jar
Posted by GitBox <gi...@apache.org>.
janhoy commented on a change in pull request #582:
URL: https://github.com/apache/solr/pull/582#discussion_r797040652
##########
File path: versions.lock
##########
@@ -29,7 +29,7 @@ com.google.cloud:google-cloud-core:1.94.3 (3 constraints: da2307c0)
com.google.cloud:google-cloud-core-http:1.94.3 (2 constraints: 651543d8)
com.google.cloud:google-cloud-storage:1.113.14 (2 constraints: 10143aa3)
com.google.code.findbugs:annotations:3.0.1 (1 constraints: 0605fb35)
-com.google.code.findbugs:jsr305:3.0.2 (9 constraints: 057f5545)
+com.google.code.findbugs:jsr305:3.0.1 (1 constraints: b70f3485)
Review comment:
I think this is the testOnly inclusion mentioned earlier - the binary distro now does not include these jars. I think the test-only include is to support the annotations in IDEs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley commented on a change in pull request #582: SOLR-15966 Get rid of WEB-INF/lib/jsr305-3.0.2.jar
Posted by GitBox <gi...@apache.org>.
dsmiley commented on a change in pull request #582:
URL: https://github.com/apache/solr/pull/582#discussion_r796917800
##########
File path: versions.lock
##########
@@ -29,7 +29,7 @@ com.google.cloud:google-cloud-core:1.94.3 (3 constraints: da2307c0)
com.google.cloud:google-cloud-core-http:1.94.3 (2 constraints: 651543d8)
com.google.cloud:google-cloud-storage:1.113.14 (2 constraints: 10143aa3)
com.google.code.findbugs:annotations:3.0.1 (1 constraints: 0605fb35)
-com.google.code.findbugs:jsr305:3.0.2 (9 constraints: 057f5545)
+com.google.code.findbugs:jsr305:3.0.1 (1 constraints: b70f3485)
Review comment:
one remains...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on a change in pull request #582: SOLR-15966 Get rid of WEB-INF/lib/jsr305-3.0.2.jar
Posted by GitBox <gi...@apache.org>.
janhoy commented on a change in pull request #582:
URL: https://github.com/apache/solr/pull/582#discussion_r796435683
##########
File path: versions.lock
##########
@@ -29,7 +29,7 @@ com.google.cloud:google-cloud-core:1.94.3 (3 constraints: da2307c0)
com.google.cloud:google-cloud-core-http:1.94.3 (2 constraints: 651543d8)
com.google.cloud:google-cloud-storage:1.113.14 (2 constraints: 10143aa3)
com.google.code.findbugs:annotations:3.0.1 (1 constraints: 0605fb35)
-com.google.code.findbugs:jsr305:3.0.2 (9 constraints: 057f5545)
+com.google.code.findbugs:jsr305:3.0.2 (2 constraints: cd195721)
Review comment:
I excluded it from ref-guide and s3-repository as well, and now we're down to only
```
./gradlew why --hash=b70f3485
> Task :why
com.google.code.findbugs:jsr305:3.0.1
com.google.code.findbugs:annotations -> 3.0.1
```
I think this one is the testOnly from https://github.com/apache/solr/blob/main/gradle/hacks/solr.findbugs.gradle#L40
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org