You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Ravi Prakash (JIRA)" <ji...@apache.org> on 2015/05/01 00:03:06 UTC
[jira] [Commented] (HADOOP-11866) increase readability and
reliability of checkstyle, shellcheck, and whitespace reports
[ https://issues.apache.org/jira/browse/HADOOP-11866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14522356#comment-14522356 ]
Ravi Prakash commented on HADOOP-11866:
---------------------------------------
Thanks for the work!
# rm "${file}" 2>/dev/null is unnecessary
# emtpy -> empty
These are minor nitpicks though and its fine to follow up in a different JIRA. The changes look good to me. +1
> increase readability and reliability of checkstyle, shellcheck, and whitespace reports
> --------------------------------------------------------------------------------------
>
> Key: HADOOP-11866
> URL: https://issues.apache.org/jira/browse/HADOOP-11866
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Naganarasimha G R
> Assignee: Allen Wittenauer
> Priority: Minor
> Attachments: HADOOP-11866-05.patch, HADOOP-11866-06.patch, HADOOP-11866-07.patch, HADOOP-11866-checkstyle.patch, HADOOP-11866.20150422-1.patch, HADOOP-11866.20150423-1.patch, HADOOP-11866.20150427-1.patch
>
>
> HADOOP-11746 supports listing of the lines which has trailing white spaces but doesn't inform patch line number. Without this report output will not be of much help as in most cases it reports blank lines. Also for the first timers it would be difficult to understand the output check style script hence adding an header
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)