You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/03/15 15:11:38 UTC
[GitHub] [skywalking-kubernetes] vision-ken opened a new pull request #41:
fix https://github.com/apache/skywalking/issues/4512
vision-ken opened a new pull request #41: fix https://github.com/apache/skywalking/issues/4512
URL: https://github.com/apache/skywalking-kubernetes/pull/41
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-kubernetes] innerpeacez commented on issue #41: fix
https://github.com/apache/skywalking/issues/4512
Posted by GitBox <gi...@apache.org>.
innerpeacez commented on issue #41: fix https://github.com/apache/skywalking/issues/4512
URL: https://github.com/apache/skywalking-kubernetes/pull/41#issuecomment-602361866
It doesn't matter where the configuration is placed, as long as it can be read when the container starts. I want to put it under the `elasticsearch.config.xx` related to put together for easy management.Because some other configurations of es have been placed under `elasticsearch.config.xx`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-kubernetes] innerpeacez commented on a change in pull
request #41: fix https://github.com/apache/skywalking/issues/4512
Posted by GitBox <gi...@apache.org>.
innerpeacez commented on a change in pull request #41: fix https://github.com/apache/skywalking/issues/4512
URL: https://github.com/apache/skywalking-kubernetes/pull/41#discussion_r396201670
##########
File path: chart/skywalking/values.yaml
##########
@@ -56,8 +56,6 @@ oap:
env:
# more env, please refer to https://hub.docker.com/r/apache/skywalking-oap-server
Review comment:
`values-es6.yaml` also needs tips
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-kubernetes] vision-ken commented on issue #41: fix
https://github.com/apache/skywalking/issues/4512
Posted by GitBox <gi...@apache.org>.
vision-ken commented on issue #41: fix https://github.com/apache/skywalking/issues/4512
URL: https://github.com/apache/skywalking-kubernetes/pull/41#issuecomment-602342966
@innerpeacez
Can't find deployment.yaml file in the project.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-kubernetes] innerpeacez commented on issue #41: fix
https://github.com/apache/skywalking/issues/4512
Posted by GitBox <gi...@apache.org>.
innerpeacez commented on issue #41: fix https://github.com/apache/skywalking/issues/4512
URL: https://github.com/apache/skywalking-kubernetes/pull/41#issuecomment-599296213
Elasticsearch related configuration is expressed as `elasticsearch.config.xxx`, and you also need to modify the `deployment.yaml` file and give tips in the `values.yaml` file.
 @vision-ken
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-kubernetes] vision-ken commented on issue #41: fix
https://github.com/apache/skywalking/issues/4512
Posted by GitBox <gi...@apache.org>.
vision-ken commented on issue #41: fix https://github.com/apache/skywalking/issues/4512
URL: https://github.com/apache/skywalking-kubernetes/pull/41#issuecomment-602352183
@innerpeacez
I think it should be added here but not `elasticsearch.config.xxx`:
```yaml
oap:
env:
SW_ES_USER: "elastic"
SW_ES_PASSWORD: "xxx"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-kubernetes] vision-ken commented on issue #41: fix
https://github.com/apache/skywalking/issues/4512
Posted by GitBox <gi...@apache.org>.
vision-ken commented on issue #41: fix https://github.com/apache/skywalking/issues/4512
URL: https://github.com/apache/skywalking-kubernetes/pull/41#issuecomment-602364681
@innerpeacez
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-kubernetes] innerpeacez commented on issue #41: fix
https://github.com/apache/skywalking/issues/4512
Posted by GitBox <gi...@apache.org>.
innerpeacez commented on issue #41: fix https://github.com/apache/skywalking/issues/4512
URL: https://github.com/apache/skywalking-kubernetes/pull/41#issuecomment-602317471
Hello, do you want to continue to do this PR? @vision-ken
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-kubernetes] vision-ken commented on issue #41: fix
https://github.com/apache/skywalking/issues/4512
Posted by GitBox <gi...@apache.org>.
vision-ken commented on issue #41: fix https://github.com/apache/skywalking/issues/4512
URL: https://github.com/apache/skywalking-kubernetes/pull/41#issuecomment-602356876
I'v changed the `es-init.job.yaml` file and `oap-deployment.yaml` file no need to change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-kubernetes] vision-ken edited a comment on issue #41:
fix https://github.com/apache/skywalking/issues/4512
Posted by GitBox <gi...@apache.org>.
vision-ken edited a comment on issue #41: fix https://github.com/apache/skywalking/issues/4512
URL: https://github.com/apache/skywalking-kubernetes/pull/41#issuecomment-602342966
@innerpeacez
Can't find `deployment.yaml` file in the project.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-kubernetes] vision-ken commented on issue #41: fix
https://github.com/apache/skywalking/issues/4512
Posted by GitBox <gi...@apache.org>.
vision-ken commented on issue #41: fix https://github.com/apache/skywalking/issues/4512
URL: https://github.com/apache/skywalking-kubernetes/pull/41#issuecomment-602362695
@innerpeacez Ok, I’ll make a change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-kubernetes] innerpeacez commented on a change in pull
request #41: fix https://github.com/apache/skywalking/issues/4512
Posted by GitBox <gi...@apache.org>.
innerpeacez commented on a change in pull request #41: fix https://github.com/apache/skywalking/issues/4512
URL: https://github.com/apache/skywalking-kubernetes/pull/41#discussion_r396201638
##########
File path: chart/skywalking/templates/es-init.job.yaml
##########
@@ -55,7 +55,11 @@ spec:
{{- else }}
value: "{{ .Values.elasticsearch.config.host }}:{{ .Values.elasticsearch.config.port.http }}"
{{- end }}
+ - name: SW_ES_USER
Review comment:
Need to determine whether these two keys exist, some users do not need to fill in these two keys. And you need to note that `elasticseach.config.xx` is currently only available to users who already have elasticseach.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-kubernetes] innerpeacez merged pull request #41: fix
https://github.com/apache/skywalking/issues/4512
Posted by GitBox <gi...@apache.org>.
innerpeacez merged pull request #41: fix https://github.com/apache/skywalking/issues/4512
URL: https://github.com/apache/skywalking-kubernetes/pull/41
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-kubernetes] innerpeacez commented on issue #41: fix
https://github.com/apache/skywalking/issues/4512
Posted by GitBox <gi...@apache.org>.
innerpeacez commented on issue #41: fix https://github.com/apache/skywalking/issues/4512
URL: https://github.com/apache/skywalking-kubernetes/pull/41#issuecomment-602347476
> @innerpeacez
> Can't find `deployment.yaml` file in the project.
`oap-deployment.yaml` and `es-init.job.yaml`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services