svn commit: r1900794 - in /spamassassin/trunk: MANIFEST t/perlcritic.pl t/perlcritic.t xt/60_perlcritic.t

[si...@apache.org]

Author: sidney
Date: Tue May 10 23:23:31 2022
New Revision: 1900794

URL: http://svn.apache.org/viewvc?rev=1900794&view=rev
Log:
move percritic test code from xt directory which is not in MANIFEST

Added:
    spamassassin/trunk/t/perlcritic.pl   (with props)
Removed:
    spamassassin/trunk/xt/60_perlcritic.t
Modified:
    spamassassin/trunk/MANIFEST
    spamassassin/trunk/t/perlcritic.t

Modified: spamassassin/trunk/MANIFEST
URL: http://svn.apache.org/viewvc/spamassassin/trunk/MANIFEST?rev=1900794&r1=1900793&r2=1900794&view=diff
==============================================================================
--- spamassassin/trunk/MANIFEST (original)
+++ spamassassin/trunk/MANIFEST Tue May 10 23:23:31 2022
@@ -549,6 +549,7 @@ t/prefs_include.t
 t/priorities.t
 t/priorities_welcome_block.t
 t/perlcritic.t
+t/perlcritic.pl
 t/pyzor.t
 t/razor2.t
 t/rcvd_parser.t

Added: spamassassin/trunk/t/perlcritic.pl
URL: http://svn.apache.org/viewvc/spamassassin/trunk/t/perlcritic.pl?rev=1900794&view=auto
==============================================================================
--- spamassassin/trunk/t/perlcritic.pl (added)
+++ spamassassin/trunk/t/perlcritic.pl Tue May 10 23:23:31 2022
@@ -0,0 +1,31 @@
+#!/usr/bin/perl
+
+use lib '.'; use lib 't';
+use SATest; sa_t_init('perlcritic');
+
+use strict;
+use warnings;
+use Test::More;
+use English qw(-no_match_vars);
+
+plan skip_all => "This test requires Test::Perl::Critic" unless (eval { require Test::Perl::Critic; 1} );
+plan skip_all => "PerlCritic test cannot run in Taint mode" if (${^TAINT});
+
+open RC, ">../t/log/perlcritic.rc"  or die "cannot create t/log/perlcritic.rc";
+
+# we should remove some of these excludes if/when we feel like fixing 'em!
+print RC q{
+
+  severity = 5
+  verbose = 10
+  exclude = ValuesAndExpressions::ProhibitLeadingZeros InputOutput::ProhibitBarewordFileHandles InputOutput::ProhibitTwoArgOpen BuiltinFunctions::ProhibitStringyEval InputOutput::ProhibitInteractiveTest
+
+  [TestingAndDebugging::ProhibitNoStrict]
+  allow = refs
+
+}  or die "cannot write t/log/perlcritic.rc";
+close RC  or die "cannot close t/log/perlcritic.rc";
+
+Test::Perl::Critic->import( -profile => "../t/log/perlcritic.rc" );
+all_critic_ok("../blib");
+

Propchange: spamassassin/trunk/t/perlcritic.pl
------------------------------------------------------------------------------
    svn:executable = *

Modified: spamassassin/trunk/t/perlcritic.t
URL: http://svn.apache.org/viewvc/spamassassin/trunk/t/perlcritic.t?rev=1900794&r1=1900793&r2=1900794&view=diff
==============================================================================
--- spamassassin/trunk/t/perlcritic.t (original)
+++ spamassassin/trunk/t/perlcritic.t Tue May 10 23:23:31 2022
@@ -1,5 +1,6 @@
-#!/usr/bin/perl
+#!/usr/bin/perl -T
+# Wrapper around test until perlcritic fixes bug running under -T
 $ENV{'PATH'} = '/bin:/usr/bin';
--d "xt" && "$^X xt/60_perlcritic.t" =~ /(.*)/ ||
-           "$^X ../xt/60_perlcritic.t" =~ /(.*)/;
+-d "t" && "$^X t/perlcritic.pl" =~ /(.*)/ ||
+    "$^X perlcritic.pl" =~ /(.*)/;
 exec($1);