You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Howard M. Lewis Ship (JIRA)" <ta...@jakarta.apache.org> on 2005/12/01 22:43:31 UTC

[jira] Created: (TAPESTRY-783) contrib:Tree fails with NullPointerException

contrib:Tree fails with NullPointerException
--------------------------------------------

         Key: TAPESTRY-783
         URL: http://issues.apache.org/jira/browse/TAPESTRY-783
     Project: Tapestry
        Type: Bug
  Components: Contrib  
    Versions: 4.0    
 Environment: 4.0-beta-13
    Reporter: Howard M. Lewis Ship
 Assigned to: Howard M. Lewis Ship 


Bleh!  contrib:Tree is a "dump" component; the original author, TsV, dumped it on Tapestry and took off with no code or external documentation.

It currently blows up:

# org.apache.hivemind.util.Defense.notNull(Defense.java:41)
# org.apache.tapestry.asset.PrivateAsset.<init>(PrivateAsset.java:55)
# org.apache.tapestry.asset.PrivateAsset.<init>(PrivateAsset.java:47)
# org.apache.tapestry.workbench.tree.examples.fsmodel.AssetsHolder.getAssetForCloseNode(AssetsHolder.java:61)
# org.apache.tapestry.workbench.tree.examples.fsmodel.NodeRenderFactory$CFileSystemRender.getAsset(NodeRenderFactory.java:104)
# org.apache.tapestry.workbench.tree.examples.fsmodel.NodeRenderFactory$CFileSystemRender.render(NodeRenderFactory.java:81)
# org.apache.tapestry.components.Delegator.renderComponent(Delegator.java:44)
# org.apache.tapestry.AbstractComponent.render(AbstractComponent.java:617)
# org.apache.tapestry.AbstractComponent.renderBody(AbstractComponent.java:434)
# org.apache.tapestry.link.DefaultLinkRenderer.renderLink(DefaultLinkRenderer.java:81)
# org.apache.tapestry.link.AbstractLinkComponent.renderComponent(AbstractLinkComponent.java:95)
# org.apache.tapestry.AbstractComponent.render(AbstractComponent.java:617)
# org.apache.tapestry.AbstractComponent.renderBody(AbstractComponent.java:434)
# org.apache.tapestry.components.IfBean.renderComponent(IfBean.java:86)
# org.apache.tapestry.AbstractComponent.render(AbstractComponent.java:617)
# org.apache.tapestry.AbstractComponent.renderBody(AbstractComponent.java:434)
# org.apache.tapestry.components.Any.renderComponent(Any.java:48)
# org.apache.tapestry.AbstractComponent.render(AbstractComponent.java:617)
# org.apache.tapestry.BaseComponent.renderComponent(BaseComponent.java:92) 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org


[jira] Updated: (TAPESTRY-783) contrib:Tree fails with NullPointerException

Posted by "Howard M. Lewis Ship (JIRA)" <ta...@jakarta.apache.org>.
     [ http://issues.apache.org/jira/browse/TAPESTRY-783?page=all ]

Howard M. Lewis Ship updated TAPESTRY-783:
------------------------------------------

    Priority: Critical  (was: Major)

The core issue is that the asset engine service is needed when constructing PrivateAsset instances.  Now, at the core of this, is the fact that we're trying to create PrivateAsset instances in the first place; that's a bad idea, they should be passed in to components and other code, not created on the fly. Bad design.

> contrib:Tree fails with NullPointerException
> --------------------------------------------
>
>          Key: TAPESTRY-783
>          URL: http://issues.apache.org/jira/browse/TAPESTRY-783
>      Project: Tapestry
>         Type: Bug
>   Components: Contrib
>     Versions: 4.0
>  Environment: 4.0-beta-13
>     Reporter: Howard M. Lewis Ship
>     Assignee: Howard M. Lewis Ship
>     Priority: Critical

>
> Bleh!  contrib:Tree is a "dump" component; the original author, TsV, dumped it on Tapestry and took off with no code or external documentation.
> It currently blows up:
> # org.apache.hivemind.util.Defense.notNull(Defense.java:41)
> # org.apache.tapestry.asset.PrivateAsset.<init>(PrivateAsset.java:55)
> # org.apache.tapestry.asset.PrivateAsset.<init>(PrivateAsset.java:47)
> # org.apache.tapestry.workbench.tree.examples.fsmodel.AssetsHolder.getAssetForCloseNode(AssetsHolder.java:61)
> # org.apache.tapestry.workbench.tree.examples.fsmodel.NodeRenderFactory$CFileSystemRender.getAsset(NodeRenderFactory.java:104)
> # org.apache.tapestry.workbench.tree.examples.fsmodel.NodeRenderFactory$CFileSystemRender.render(NodeRenderFactory.java:81)
> # org.apache.tapestry.components.Delegator.renderComponent(Delegator.java:44)
> # org.apache.tapestry.AbstractComponent.render(AbstractComponent.java:617)
> # org.apache.tapestry.AbstractComponent.renderBody(AbstractComponent.java:434)
> # org.apache.tapestry.link.DefaultLinkRenderer.renderLink(DefaultLinkRenderer.java:81)
> # org.apache.tapestry.link.AbstractLinkComponent.renderComponent(AbstractLinkComponent.java:95)
> # org.apache.tapestry.AbstractComponent.render(AbstractComponent.java:617)
> # org.apache.tapestry.AbstractComponent.renderBody(AbstractComponent.java:434)
> # org.apache.tapestry.components.IfBean.renderComponent(IfBean.java:86)
> # org.apache.tapestry.AbstractComponent.render(AbstractComponent.java:617)
> # org.apache.tapestry.AbstractComponent.renderBody(AbstractComponent.java:434)
> # org.apache.tapestry.components.Any.renderComponent(Any.java:48)
> # org.apache.tapestry.AbstractComponent.render(AbstractComponent.java:617)
> # org.apache.tapestry.BaseComponent.renderComponent(BaseComponent.java:92) 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org


[jira] Commented: (TAPESTRY-783) contrib:Tree fails with NullPointerException

Posted by "Howard M. Lewis Ship (JIRA)" <ta...@jakarta.apache.org>.
    [ http://issues.apache.org/jira/browse/TAPESTRY-783?page=comments#action_12359085 ] 

Howard M. Lewis Ship commented on TAPESTRY-783:
-----------------------------------------------

Changes between 3.0 and 4.0 require that the asset service be available when creating PrivateAsset instances.

> contrib:Tree fails with NullPointerException
> --------------------------------------------
>
>          Key: TAPESTRY-783
>          URL: http://issues.apache.org/jira/browse/TAPESTRY-783
>      Project: Tapestry
>         Type: Bug
>   Components: Contrib
>     Versions: 4.0
>  Environment: 4.0-beta-13
>     Reporter: Howard M. Lewis Ship
>     Assignee: Howard M. Lewis Ship

>
> Bleh!  contrib:Tree is a "dump" component; the original author, TsV, dumped it on Tapestry and took off with no code or external documentation.
> It currently blows up:
> # org.apache.hivemind.util.Defense.notNull(Defense.java:41)
> # org.apache.tapestry.asset.PrivateAsset.<init>(PrivateAsset.java:55)
> # org.apache.tapestry.asset.PrivateAsset.<init>(PrivateAsset.java:47)
> # org.apache.tapestry.workbench.tree.examples.fsmodel.AssetsHolder.getAssetForCloseNode(AssetsHolder.java:61)
> # org.apache.tapestry.workbench.tree.examples.fsmodel.NodeRenderFactory$CFileSystemRender.getAsset(NodeRenderFactory.java:104)
> # org.apache.tapestry.workbench.tree.examples.fsmodel.NodeRenderFactory$CFileSystemRender.render(NodeRenderFactory.java:81)
> # org.apache.tapestry.components.Delegator.renderComponent(Delegator.java:44)
> # org.apache.tapestry.AbstractComponent.render(AbstractComponent.java:617)
> # org.apache.tapestry.AbstractComponent.renderBody(AbstractComponent.java:434)
> # org.apache.tapestry.link.DefaultLinkRenderer.renderLink(DefaultLinkRenderer.java:81)
> # org.apache.tapestry.link.AbstractLinkComponent.renderComponent(AbstractLinkComponent.java:95)
> # org.apache.tapestry.AbstractComponent.render(AbstractComponent.java:617)
> # org.apache.tapestry.AbstractComponent.renderBody(AbstractComponent.java:434)
> # org.apache.tapestry.components.IfBean.renderComponent(IfBean.java:86)
> # org.apache.tapestry.AbstractComponent.render(AbstractComponent.java:617)
> # org.apache.tapestry.AbstractComponent.renderBody(AbstractComponent.java:434)
> # org.apache.tapestry.components.Any.renderComponent(Any.java:48)
> # org.apache.tapestry.AbstractComponent.render(AbstractComponent.java:617)
> # org.apache.tapestry.BaseComponent.renderComponent(BaseComponent.java:92) 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org


[jira] Closed: (TAPESTRY-783) contrib:Tree fails with NullPointerException

Posted by "Howard M. Lewis Ship (JIRA)" <ta...@jakarta.apache.org>.
     [ http://issues.apache.org/jira/browse/TAPESTRY-783?page=all ]
     
Howard M. Lewis Ship closed TAPESTRY-783:
-----------------------------------------

    Fix Version: 4.0
     Resolution: Fixed

I'd like to deprecate or rewrite this component, but instead, I'd just say that the Tacos implementation is better.

> contrib:Tree fails with NullPointerException
> --------------------------------------------
>
>          Key: TAPESTRY-783
>          URL: http://issues.apache.org/jira/browse/TAPESTRY-783
>      Project: Tapestry
>         Type: Bug
>   Components: Contrib
>     Versions: 4.0
>  Environment: 4.0-beta-13
>     Reporter: Howard M. Lewis Ship
>     Assignee: Howard M. Lewis Ship
>     Priority: Critical
>      Fix For: 4.0

>
> Bleh!  contrib:Tree is a "dump" component; the original author, TsV, dumped it on Tapestry and took off with no code or external documentation.
> It currently blows up:
> # org.apache.hivemind.util.Defense.notNull(Defense.java:41)
> # org.apache.tapestry.asset.PrivateAsset.<init>(PrivateAsset.java:55)
> # org.apache.tapestry.asset.PrivateAsset.<init>(PrivateAsset.java:47)
> # org.apache.tapestry.workbench.tree.examples.fsmodel.AssetsHolder.getAssetForCloseNode(AssetsHolder.java:61)
> # org.apache.tapestry.workbench.tree.examples.fsmodel.NodeRenderFactory$CFileSystemRender.getAsset(NodeRenderFactory.java:104)
> # org.apache.tapestry.workbench.tree.examples.fsmodel.NodeRenderFactory$CFileSystemRender.render(NodeRenderFactory.java:81)
> # org.apache.tapestry.components.Delegator.renderComponent(Delegator.java:44)
> # org.apache.tapestry.AbstractComponent.render(AbstractComponent.java:617)
> # org.apache.tapestry.AbstractComponent.renderBody(AbstractComponent.java:434)
> # org.apache.tapestry.link.DefaultLinkRenderer.renderLink(DefaultLinkRenderer.java:81)
> # org.apache.tapestry.link.AbstractLinkComponent.renderComponent(AbstractLinkComponent.java:95)
> # org.apache.tapestry.AbstractComponent.render(AbstractComponent.java:617)
> # org.apache.tapestry.AbstractComponent.renderBody(AbstractComponent.java:434)
> # org.apache.tapestry.components.IfBean.renderComponent(IfBean.java:86)
> # org.apache.tapestry.AbstractComponent.render(AbstractComponent.java:617)
> # org.apache.tapestry.AbstractComponent.renderBody(AbstractComponent.java:434)
> # org.apache.tapestry.components.Any.renderComponent(Any.java:48)
> # org.apache.tapestry.AbstractComponent.render(AbstractComponent.java:617)
> # org.apache.tapestry.BaseComponent.renderComponent(BaseComponent.java:92) 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org