You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/03/21 18:26:54 UTC

[GitHub] [incubator-mxnet] roywei opened a new pull request #14494: [MXNet-1340][Fit API]Adding train history class

roywei opened a new pull request #14494: [MXNet-1340][Fit API]Adding train history class
URL: https://github.com/apache/incubator-mxnet/pull/14494
 
 
   ## Description ##
   In the previous [Fit-API design doc](https://cwiki.apache.org/confluence/display/MXNET/Gluon+Fit+API+-+Tech+Design#GluonFitAPI-TechDesign-Estimatorclass) , training statistics was stored in a dictionary,  some values are stored as a list such learning rates and training accuraccy over epochs. users has to understand the underlying data structure inorder to  access the statistics. 
   This PR introduce a Train History object, and this will be the interface for event handlers to access training information.
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [ ] The PR title starts with [MXNET-1340](https://issues.apache.org/jira/browse/MXNET-1340) created
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
   - [ ] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments are documented. 
   - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
   - Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - [ ] Feature1, tests, (and when applicable, API doc)
   - [ ] Feature2, tests, (and when applicable, API doc)
   
   ## Comments ##
   - If this change is a backward incompatible change, why must this change be made.
   - Interesting edge cases to note here
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services