[GitHub] [spark] HeartSaVioR commented on a change in pull request #27016: [SPARK-30360][UI] Avoid Redact classpath entries in History Server UI

[GitBox <gi...@apache.org>]

HeartSaVioR commented on a change in pull request #27016: [SPARK-30360][UI] Avoid Redact classpath entries in History Server UI
URL: https://github.com/apache/spark/pull/27016#discussion_r361675571
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala
 ##########
 @@ -255,9 +255,14 @@ private[spark] class EventLoggingListener(
     // ...
     // where jvmInformation, sparkProperties, etc. are sequence of tuples.
     // We go through the various  of properties and redact sensitive information from them.
-    val redactedProps = event.environmentDetails.map{ case (name, props) =>
-      name -> Utils.redact(sparkConf, props)
-    }
+    val noRedactProps = Seq("Classpath Entries")
+    val redactedProps = event.environmentDetails
+      .map {
 
 Review comment:
   nit: This can be done like below, as they fit in one-line per each:
   
   ```
   val redactedProps = event.environmentDetails.map {
     case (name, props) if noRedactProps.contains(name) => name -> props
     case (name, props) => name -> Utils.redact(sparkConf, props)
   }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org