[GitHub] necouchman commented on a change in pull request #371: GUACAMOLE-717: Handle LDAPException gracefully when doing a search

[GitBox <gi...@apache.org>]

necouchman commented on a change in pull request #371: GUACAMOLE-717: Handle LDAPException gracefully when doing a search
URL: https://github.com/apache/guacamole-client/pull/371#discussion_r251181188
 
 

 ##########
 File path: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/ObjectQueryService.java
 ##########
 @@ -221,6 +221,11 @@ public String generateQuery(String filter,
                         logger.debug("Got a referral, but configured to not follow them.", e);
                     }
                 }
+                
+                catch (LDAPException e) {
+                  logger.warn("Failed to process an LDAP search result. Error was: {}",e.resultCodeToString());
+                  logger.debug("Error processing LDAPEntry search result.",e);
 
 Review comment:
   Such a minor nit-pick,but spaces,please,after the commas.
   
   :smile:

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services