[GitHub] [incubator-streampark] wolfboys commented on a diff in pull request #1991: [Bug] Failed to mark the latest savepoint and checkpoint #1989

[GitBox <gi...@apache.org>]

wolfboys commented on code in PR #1991:
URL: https://github.com/apache/incubator-streampark/pull/1991#discussion_r1017538340


##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/ApplicationServiceImpl.java:
##########
@@ -449,8 +449,9 @@ public boolean checkAlter(Application application) {
         if (!FlinkAppState.CANCELED.equals(state)) {
             return false;
         }
-        Long useId = FlinkTrackingTask.getCanceledJobUserId(appId);
-        return useId == null || application.getUserId().longValue() != FlinkTrackingTask.getCanceledJobUserId(appId).longValue();
+        long cancelUserId = FlinkTrackingTask.getCanceledJobUserId(appId).longValue();

Review Comment:
   Maybe a NullPointException will occur



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org