[Roller-JIRA] Closed: (ROL-1158) OracleDialect => Oracle9Dialect in HibernateRefererManagerImpl

["Henri Yandell (JIRA)" <no...@atlassian.com>]

     [ http://opensource.atlassian.com/projects/roller/browse/ROL-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Henri Yandell closed ROL-1158.
------------------------------

       Resolution: Fixed
    Fix Version/s: 4.0

svn ci -m "Applying the fix from ROL-1158. Use Oracle9Dialect (the superclass) and not OracleDialect. Thanks Teppo." apps/weblogger/src/java/org/apache/roller/weblogger/business/hibernate/HibernateRefererManagerImpl.java

Sending       apps/weblogger/src/java/org/apache/roller/weblogger/business/hibernate/HibernateRefererManagerImpl.java
Transmitting file data .
Committed revision 551264.

> OracleDialect => Oracle9Dialect in HibernateRefererManagerImpl
> --------------------------------------------------------------
>
>                 Key: ROL-1158
>                 URL: http://opensource.atlassian.com/projects/roller/browse/ROL-1158
>             Project: Roller
>          Issue Type: Bug
>          Components: Database Access & Data Model
>    Affects Versions: 2.3
>            Reporter: Teppo Kurki
>            Assignee: Roller Unassigned
>            Priority: Trivial
>             Fix For: 4.0
>
>
> If the Hibernate dialect is set to Oracle9Dialect HibernateRefererManagerImpl.getDaysPopularWebsites will try to use the wrong sql flavor, since the Oracle test uses 
>             } else if (currentDialect instanceof OracleDialect) {
> and OracleDialect is actually a subclass of Oracle9Dialect. See http://www.hibernate.org/hib_docs/v3/api/org/hibernate/dialect/OracleDialect.html.
> This results in "ORA-00933: SQL command not properly ended" error.
> The easy fix is to use Oracle9Dialect when testing for "is this Oracle".
> This seems to be the only place where OracleDialect or Oracle9Dialect is referenced in Roller.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/roller/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira