[GitHub] [storm] agresch commented on a diff in pull request #3540: [STORM-3916] Add Round Robin Scheduling strategy with optional node limit

["agresch (via GitHub)" <gi...@apache.org>]

agresch commented on code in PR #3540:
URL: https://github.com/apache/storm/pull/3540#discussion_r1218307249


##########
storm-client/src/jvm/org/apache/storm/Config.java:
##########
@@ -859,9 +859,11 @@ public class Config extends HashMap<String, Object> {
     @IsString
     public static final String STORM_DO_AS_USER = "storm.doAsUser";
     /**
-     * The number of machines that should be used by this topology to isolate it from all others. Set storm.scheduler to
-     * org.apache.storm.scheduler.multitenant.MultitenantScheduler
-     */
+     * The number of machines that should be used by this topology to isolate it from all others.

Review Comment:
   Unrelated to your change, but hopefully you can address...  I don't understand why specifying a number of machines causes isolation.  Your PR mentions this is a max number of machines.  Can you add/modify the description to clarify this config description?



##########
storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/BaseResourceAwareStrategy.java:
##########
@@ -164,6 +168,7 @@ public SchedulingResult schedule(Cluster cluster, TopologyDetails td) {
 
         //order executors to be scheduled
         List<ExecutorDetails> orderedExecutors = execSorter.sortExecutors(unassignedExecutors);
+        isolateAckersToEnd(orderedExecutors);

Review Comment:
   this seems to be a behavior change?  Why was this added?



##########
storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/BaseResourceAwareStrategy.java:
##########
@@ -527,13 +538,13 @@ protected SchedulingResult scheduleExecutorsOnNodes(List<ExecutorDetails> ordere
             if (execIndex == 0) {
                 break;
             } else {
-                searcherState.backtrack(execToComp, nodeForExec[execIndex - 1], workerSlotForExec[execIndex - 1]);

Review Comment:
   why did this line change?



##########
storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/BaseResourceAwareStrategy.java:
##########
@@ -123,6 +123,10 @@ public BaseResourceAwareStrategy(boolean sortNodesForEachExecutor, NodeSortType
         this.nodeSortType = nodeSortType;
     }
 
+    public boolean isSortNodesForEachExecutor() {

Review Comment:
   where is this used?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org