You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Daniel Voros (JIRA)" <ji...@apache.org> on 2018/10/02 08:39:00 UTC
[jira] [Commented] (HIVE-20191) PreCommit patch application doesn't
fail if patch is empty
[ https://issues.apache.org/jira/browse/HIVE-20191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16635161#comment-16635161 ]
Daniel Voros commented on HIVE-20191:
-------------------------------------
Updated [https://cwiki.apache.org/confluence/display/Hive/HowToContribute], thanks again [~kgyrtkirk]!
> PreCommit patch application doesn't fail if patch is empty
> ----------------------------------------------------------
>
> Key: HIVE-20191
> URL: https://issues.apache.org/jira/browse/HIVE-20191
> Project: Hive
> Issue Type: Bug
> Components: Testing Infrastructure
> Reporter: Daniel Voros
> Assignee: Daniel Voros
> Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-20191.1.patch
>
>
> I've created some backport tickets to branch-3 (e.g. HIVE-20181) and made the mistake of uploading the patch files with wrong filename ({{.}} instead of {{-}} between version and branch).
> These get applied on master, where they're already present, since {{git apply}} with {{-3}} won't fail if patch is already there. Tests are run on master instead of failing.
> I think the patch application should fail if the patch is empty and branch selection logic should probably fail too if the patch name is malformed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)