You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/12/13 23:08:51 UTC
[GitHub] [pinot] walterddr opened a new pull request, #9983: [multistage][bugfix] fixing empty response unable to convert issue
walterddr opened a new pull request, #9983:
URL: https://github.com/apache/pinot/pull/9983
this fixes #9980.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr commented on a diff in pull request #9983: [multistage][bugfix] fixing empty response unable to convert issue
Posted by GitBox <gi...@apache.org>.
walterddr commented on code in PR #9983:
URL: https://github.com/apache/pinot/pull/9983#discussion_r1047845778
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/blocks/results/BaseResultsBlock.java:
##########
@@ -158,6 +158,11 @@ public void setNumServerThreads(int numServerThreads) {
_numServerThreads = numServerThreads;
}
+ /**
+ * Indicate the size of the result.
+ */
+ public abstract long getNumRecords();
Review Comment:
sounds good!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr merged pull request #9983: [multistage][bugfix] fixing empty response unable to convert issue
Posted by GitBox <gi...@apache.org>.
walterddr merged PR #9983:
URL: https://github.com/apache/pinot/pull/9983
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #9983: [multistage][bugfix] fixing empty response unable to convert issue
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #9983:
URL: https://github.com/apache/pinot/pull/9983#issuecomment-1350142204
# [Codecov](https://codecov.io/gh/apache/pinot/pull/9983?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9983](https://codecov.io/gh/apache/pinot/pull/9983?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b8c5467) into [master](https://codecov.io/gh/apache/pinot/commit/0338d5d6817658b4bb1a73c0d27cf0752ead45b1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0338d5d) will **decrease** coverage by `39.05%`.
> The diff coverage is `50.00%`.
```diff
@@ Coverage Diff @@
## master #9983 +/- ##
=============================================
- Coverage 64.23% 25.18% -39.06%
+ Complexity 5126 44 -5082
=============================================
Files 1934 1977 +43
Lines 104715 106829 +2114
Branches 15992 16252 +260
=============================================
- Hits 67264 26900 -40364
- Misses 32582 77212 +44630
+ Partials 4869 2717 -2152
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `25.18% <50.00%> (?)` | |
| unittests1 | `?` | |
| unittests2 | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pinot/pull/9983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...core/operator/blocks/results/BaseResultsBlock.java](https://codecov.io/gh/apache/pinot/pull/9983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9ibG9ja3MvcmVzdWx0cy9CYXNlUmVzdWx0c0Jsb2NrLmphdmE=) | `71.69% <ø> (-15.10%)` | :arrow_down: |
| [...operator/blocks/results/ExceptionResultsBlock.java](https://codecov.io/gh/apache/pinot/pull/9983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9ibG9ja3MvcmVzdWx0cy9FeGNlcHRpb25SZXN1bHRzQmxvY2suamF2YQ==) | `66.66% <0.00%> (-8.34%)` | :arrow_down: |
| [...e/operator/blocks/results/ExplainResultsBlock.java](https://codecov.io/gh/apache/pinot/pull/9983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9ibG9ja3MvcmVzdWx0cy9FeHBsYWluUmVzdWx0c0Jsb2NrLmphdmE=) | `70.37% <0.00%> (-2.71%)` | :arrow_down: |
| [.../operator/blocks/results/MetadataResultsBlock.java](https://codecov.io/gh/apache/pinot/pull/9983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9ibG9ja3MvcmVzdWx0cy9NZXRhZGF0YVJlc3VsdHNCbG9jay5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...e/operator/LeafStageTransferableBlockOperator.java](https://codecov.io/gh/apache/pinot/pull/9983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtcXVlcnktcnVudGltZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvcXVlcnkvcnVudGltZS9vcGVyYXRvci9MZWFmU3RhZ2VUcmFuc2ZlcmFibGVCbG9ja09wZXJhdG9yLmphdmE=) | `0.00% <0.00%> (-82.66%)` | :arrow_down: |
| [...erator/blocks/results/AggregationResultsBlock.java](https://codecov.io/gh/apache/pinot/pull/9983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9ibG9ja3MvcmVzdWx0cy9BZ2dyZWdhdGlvblJlc3VsdHNCbG9jay5qYXZh) | `44.44% <100.00%> (-18.06%)` | :arrow_down: |
| [.../operator/blocks/results/DistinctResultsBlock.java](https://codecov.io/gh/apache/pinot/pull/9983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9ibG9ja3MvcmVzdWx0cy9EaXN0aW5jdFJlc3VsdHNCbG9jay5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...e/operator/blocks/results/GroupByResultsBlock.java](https://codecov.io/gh/apache/pinot/pull/9983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9ibG9ja3MvcmVzdWx0cy9Hcm91cEJ5UmVzdWx0c0Jsb2NrLmphdmE=) | `55.46% <100.00%> (-29.29%)` | :arrow_down: |
| [...operator/blocks/results/SelectionResultsBlock.java](https://codecov.io/gh/apache/pinot/pull/9983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9ibG9ja3MvcmVzdWx0cy9TZWxlY3Rpb25SZXN1bHRzQmxvY2suamF2YQ==) | `95.65% <100.00%> (+0.19%)` | :arrow_up: |
| [...in/java/org/apache/pinot/spi/utils/BytesUtils.java](https://codecov.io/gh/apache/pinot/pull/9983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvdXRpbHMvQnl0ZXNVdGlscy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1609 more](https://codecov.io/gh/apache/pinot/pull/9983/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #9983: [multistage][bugfix] fixing empty response unable to convert issue
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on code in PR #9983:
URL: https://github.com/apache/pinot/pull/9983#discussion_r1047844145
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/blocks/results/BaseResultsBlock.java:
##########
@@ -158,6 +158,11 @@ public void setNumServerThreads(int numServerThreads) {
_numServerThreads = numServerThreads;
}
+ /**
+ * Indicate the size of the result.
+ */
+ public abstract long getNumRecords();
Review Comment:
(minor) Suggest returning `int` as we cannot return a collection of over 2B records. Also suggest renaming to `getNumRows()` to be more clear that it indicates the size of `getRows()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org