You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Rajith Attapattu (Created) (JIRA)" <ji...@apache.org> on 2012/03/05 23:05:57 UTC
[jira] [Created] (QPID-3885) Improve logging in JMS client
Improve logging in JMS client
-----------------------------
Key: QPID-3885
URL: https://issues.apache.org/jira/browse/QPID-3885
Project: Qpid
Issue Type: Improvement
Components: Java Client
Affects Versions: Future
Reporter: Rajith Attapattu
Assignee: Rajith Attapattu
Priority: Minor
Fix For: 0.14
Kevin Conner provided a patch to improve our logging.
For the most part it reduces noise by downgrading most log messages from info to debug.
It also adds a if(logger.isDebugEnabled()) to save on any unnecessary (and potentially expensive) string concatenations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Resolved] (QPID-3885) Improve logging in JMS client
Posted by "Rajith Attapattu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rajith Attapattu resolved QPID-3885.
------------------------------------
Resolution: Fixed
Fix Version/s: (was: Future)
0.17
Patch applied to trunk.
> Improve logging in JMS client
> -----------------------------
>
> Key: QPID-3885
> URL: https://issues.apache.org/jira/browse/QPID-3885
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client
> Affects Versions: 0.14
> Reporter: Rajith Attapattu
> Assignee: Rajith Attapattu
> Priority: Minor
> Fix For: 0.17
>
> Attachments: logging.patch, logging.patch
>
>
> Kevin Conner provided a patch to improve our logging.
> For the most part it reduces noise by downgrading most log messages from info to debug.
> It also adds a if(logger.isDebugEnabled()) to save on any unnecessary (and potentially expensive) string concatenations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Commented] (QPID-3885) Improve logging in JMS client
Posted by "Rajith Attapattu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225453#comment-13225453 ]
Rajith Attapattu commented on QPID-3885:
----------------------------------------
"The only one which really showed up, related to performance, was
MessageProducer org.apache.qpid.client.BasicMessageProducer_0_10@658eeb10 using publish mode : ASYNC_PUBLISH_ALL
For example one of the performance tests had over 10000 entries in our log files."
This log message is **only** printed when we create a producer instance.
So I wonder why there are so many producers being created in the perf test ?
Perhaps this could be pointing to something in our JCA implementation. Perhaps worthwhile investigating.
> Improve logging in JMS client
> -----------------------------
>
> Key: QPID-3885
> URL: https://issues.apache.org/jira/browse/QPID-3885
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client
> Affects Versions: 0.14
> Reporter: Rajith Attapattu
> Assignee: Rajith Attapattu
> Priority: Minor
> Fix For: Future
>
> Attachments: logging.patch, logging.patch
>
>
> Kevin Conner provided a patch to improve our logging.
> For the most part it reduces noise by downgrading most log messages from info to debug.
> It also adds a if(logger.isDebugEnabled()) to save on any unnecessary (and potentially expensive) string concatenations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Updated] (QPID-3885) Improve logging in JMS client
Posted by "Kevin Conner (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Conner updated QPID-3885:
-------------------------------
Attachment: logging.patch
> Improve logging in JMS client
> -----------------------------
>
> Key: QPID-3885
> URL: https://issues.apache.org/jira/browse/QPID-3885
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client
> Affects Versions: 0.14
> Reporter: Rajith Attapattu
> Assignee: Rajith Attapattu
> Priority: Minor
> Fix For: Future
>
> Attachments: logging.patch, logging.patch
>
>
> Kevin Conner provided a patch to improve our logging.
> For the most part it reduces noise by downgrading most log messages from info to debug.
> It also adds a if(logger.isDebugEnabled()) to save on any unnecessary (and potentially expensive) string concatenations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Commented] (QPID-3885) Improve logging in JMS client
Posted by "Kevin Conner (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225611#comment-13225611 ]
Kevin Conner commented on QPID-3885:
------------------------------------
There were 10000 (plus a few) producers created by the test.
> Improve logging in JMS client
> -----------------------------
>
> Key: QPID-3885
> URL: https://issues.apache.org/jira/browse/QPID-3885
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client
> Affects Versions: 0.14
> Reporter: Rajith Attapattu
> Assignee: Rajith Attapattu
> Priority: Minor
> Fix For: Future
>
> Attachments: logging.patch, logging.patch
>
>
> Kevin Conner provided a patch to improve our logging.
> For the most part it reduces noise by downgrading most log messages from info to debug.
> It also adds a if(logger.isDebugEnabled()) to save on any unnecessary (and potentially expensive) string concatenations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Updated] (QPID-3885) Improve logging in JMS client
Posted by "Rajith Attapattu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rajith Attapattu updated QPID-3885:
-----------------------------------
Affects Version/s: (was: Future)
0.14
Fix Version/s: (was: 0.14)
Future
> Improve logging in JMS client
> -----------------------------
>
> Key: QPID-3885
> URL: https://issues.apache.org/jira/browse/QPID-3885
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client
> Affects Versions: 0.14
> Reporter: Rajith Attapattu
> Assignee: Rajith Attapattu
> Priority: Minor
> Fix For: Future
>
> Attachments: logging.patch
>
>
> Kevin Conner provided a patch to improve our logging.
> For the most part it reduces noise by downgrading most log messages from info to debug.
> It also adds a if(logger.isDebugEnabled()) to save on any unnecessary (and potentially expensive) string concatenations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Commented] (QPID-3885) Improve logging in JMS client
Posted by "Rob Godfrey (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222785#comment-13222785 ]
Rob Godfrey commented on QPID-3885:
-----------------------------------
As an aside, if these are patches from someone else, should he not be the one attaching them to a JIRA with the necessary copyright assignment?
> Improve logging in JMS client
> -----------------------------
>
> Key: QPID-3885
> URL: https://issues.apache.org/jira/browse/QPID-3885
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client
> Affects Versions: 0.14
> Reporter: Rajith Attapattu
> Assignee: Rajith Attapattu
> Priority: Minor
> Fix For: Future
>
> Attachments: logging.patch
>
>
> Kevin Conner provided a patch to improve our logging.
> For the most part it reduces noise by downgrading most log messages from info to debug.
> It also adds a if(logger.isDebugEnabled()) to save on any unnecessary (and potentially expensive) string concatenations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Commented] (QPID-3885) Improve logging in JMS client
Posted by "Rajith Attapattu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13224571#comment-13224571 ]
Rajith Attapattu commented on QPID-3885:
----------------------------------------
I will mark the flow control message at INFO before committing the patch.
As Rob mentioned, at some point we need to make a pass at our logging to get rid of all the junk and adjust levels properly.
> Improve logging in JMS client
> -----------------------------
>
> Key: QPID-3885
> URL: https://issues.apache.org/jira/browse/QPID-3885
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client
> Affects Versions: 0.14
> Reporter: Rajith Attapattu
> Assignee: Rajith Attapattu
> Priority: Minor
> Fix For: Future
>
> Attachments: logging.patch
>
>
> Kevin Conner provided a patch to improve our logging.
> For the most part it reduces noise by downgrading most log messages from info to debug.
> It also adds a if(logger.isDebugEnabled()) to save on any unnecessary (and potentially expensive) string concatenations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Commented] (QPID-3885) Improve logging in JMS client
Posted by "Rob Godfrey (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222789#comment-13222789 ]
Rob Godfrey commented on QPID-3885:
-----------------------------------
Agree that the highlighted messages should be more than debug (though I would probably buy info rather than warn for the first one if we get rid of all the junk that was at info level).
The rest of the changes I am comfortable with though I don't think any of these really adversely affect performance (certainly they've never shown up on any of the profiling I've done).
> Improve logging in JMS client
> -----------------------------
>
> Key: QPID-3885
> URL: https://issues.apache.org/jira/browse/QPID-3885
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client
> Affects Versions: 0.14
> Reporter: Rajith Attapattu
> Assignee: Rajith Attapattu
> Priority: Minor
> Fix For: Future
>
> Attachments: logging.patch
>
>
> Kevin Conner provided a patch to improve our logging.
> For the most part it reduces noise by downgrading most log messages from info to debug.
> It also adds a if(logger.isDebugEnabled()) to save on any unnecessary (and potentially expensive) string concatenations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Commented] (QPID-3885) Improve logging in JMS client
Posted by "Robbie Gemmell (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222750#comment-13222750 ]
Robbie Gemmell commented on QPID-3885:
--------------------------------------
Its a bit late to fix 0.14 :P
I'm not too interested in most of the changes, but I'm not sure I agree these are debug:
{noformat}
@@ -3194,7 +3194,10 @@ public abstract class AMQSession<C extends BasicMessageConsumer, P extends Basic
public void setFlowControl(final boolean active)
{
_flowControl.setFlowControl(active);
- _logger.warn("Broker enforced flow control " + (active ? "no longer in effect" : "has been enforced"));
+ if (_logger.isDebugEnabled())
+ {
+ _logger.debug("Broker enforced flow control " + (active ? "no longer in effect" : "has been enforced"));
+ }
}
public void checkFlowControl() throws InterruptedException, JMSException
@@ -3208,7 +3211,10 @@ public abstract class AMQSession<C extends BasicMessageConsumer, P extends Basic
{
_flowControl.wait(_flowControlWaitPeriod);
- _logger.warn("Message send delayed by " + (System.currentTimeMillis() + _flowControlWaitFailure - expiryTime)/1000 + "s due to broker enforced flow control");
+ if (_logger.isDebugEnabled())
+ {
+ _logger.debug("Message send delayed by " + (System.currentTimeMillis() + _flowControlWaitFailure - expiryTime)/1000 + "s due to broker enforced flow control");
+ }
}
if(!_flowControl.getFlowControl())
{
{noformat}
> Improve logging in JMS client
> -----------------------------
>
> Key: QPID-3885
> URL: https://issues.apache.org/jira/browse/QPID-3885
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client
> Affects Versions: Future
> Reporter: Rajith Attapattu
> Assignee: Rajith Attapattu
> Priority: Minor
> Fix For: 0.14
>
> Attachments: logging.patch
>
>
> Kevin Conner provided a patch to improve our logging.
> For the most part it reduces noise by downgrading most log messages from info to debug.
> It also adds a if(logger.isDebugEnabled()) to save on any unnecessary (and potentially expensive) string concatenations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Updated] (QPID-3885) Improve logging in JMS client
Posted by "Rajith Attapattu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rajith Attapattu updated QPID-3885:
-----------------------------------
Attachment: logging.patch
Attaching patch by Kevin Conner.
> Improve logging in JMS client
> -----------------------------
>
> Key: QPID-3885
> URL: https://issues.apache.org/jira/browse/QPID-3885
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client
> Affects Versions: Future
> Reporter: Rajith Attapattu
> Assignee: Rajith Attapattu
> Priority: Minor
> Fix For: 0.14
>
> Attachments: logging.patch
>
>
> Kevin Conner provided a patch to improve our logging.
> For the most part it reduces noise by downgrading most log messages from info to debug.
> It also adds a if(logger.isDebugEnabled()) to save on any unnecessary (and potentially expensive) string concatenations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Commented] (QPID-3885) Improve logging in JMS client
Posted by "Kevin Conner (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13224563#comment-13224563 ]
Kevin Conner commented on QPID-3885:
------------------------------------
The only one which really showed up, related to performance, was
MessageProducer org.apache.qpid.client.BasicMessageProducer_0_10@658eeb10 using publish mode : ASYNC_PUBLISH_ALL
For example one of the performance tests had over 10000 entries in our log files.
It was while dealing with this that I took a quick look at the others, trying to rationalise them.
As for the flow control messages I have no real opinion other than I do not believe they should be at WARN. Please change as you see fit.
> Improve logging in JMS client
> -----------------------------
>
> Key: QPID-3885
> URL: https://issues.apache.org/jira/browse/QPID-3885
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client
> Affects Versions: 0.14
> Reporter: Rajith Attapattu
> Assignee: Rajith Attapattu
> Priority: Minor
> Fix For: Future
>
> Attachments: logging.patch
>
>
> Kevin Conner provided a patch to improve our logging.
> For the most part it reduces noise by downgrading most log messages from info to debug.
> It also adds a if(logger.isDebugEnabled()) to save on any unnecessary (and potentially expensive) string concatenations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Commented] (QPID-3885) Improve logging in JMS client
Posted by "Rajith Attapattu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225631#comment-13225631 ]
Rajith Attapattu commented on QPID-3885:
----------------------------------------
Yes Weston also confirmed the same.
Just wanted to confirm the test was doing this as opposed to multiple producers being created under the hood due to a bug in our JCA code.
> Improve logging in JMS client
> -----------------------------
>
> Key: QPID-3885
> URL: https://issues.apache.org/jira/browse/QPID-3885
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client
> Affects Versions: 0.14
> Reporter: Rajith Attapattu
> Assignee: Rajith Attapattu
> Priority: Minor
> Fix For: Future
>
> Attachments: logging.patch, logging.patch
>
>
> Kevin Conner provided a patch to improve our logging.
> For the most part it reduces noise by downgrading most log messages from info to debug.
> It also adds a if(logger.isDebugEnabled()) to save on any unnecessary (and potentially expensive) string concatenations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Commented] (QPID-3885) Improve logging in JMS client
Posted by "Rajith Attapattu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222783#comment-13222783 ]
Rajith Attapattu commented on QPID-3885:
----------------------------------------
LOL, I realized I got the affects and fixed versions mixed up :D
Thanks for the review and raising questions.
These were originally marked as WARN so I assume they are meant to happen fairly infrequently.
Usually monitoring folks would like to see these kinds of messages. So I wouldn't argue about it's importance.
However Kevin may have seen this message quite frequently in the logs to downgrade this, or perhaps a mistake.
I'll ping him and see what prompted him to push this to debug.
Rajith
> Improve logging in JMS client
> -----------------------------
>
> Key: QPID-3885
> URL: https://issues.apache.org/jira/browse/QPID-3885
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client
> Affects Versions: 0.14
> Reporter: Rajith Attapattu
> Assignee: Rajith Attapattu
> Priority: Minor
> Fix For: Future
>
> Attachments: logging.patch
>
>
> Kevin Conner provided a patch to improve our logging.
> For the most part it reduces noise by downgrading most log messages from info to debug.
> It also adds a if(logger.isDebugEnabled()) to save on any unnecessary (and potentially expensive) string concatenations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org