You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ljz2051 (via GitHub)" <gi...@apache.org> on 2023/09/13 07:01:09 UTC

[GitHub] [flink] ljz2051 opened a new pull request, #23407: [FLINK-32953][docs]Add notes about changing state ttl value

ljz2051 opened a new pull request, #23407:
URL: https://github.com/apache/flink/pull/23407

   ## What is the purpose of the change
   
   This pull request add notes about changing state TTL value when restore checkpoint.
   
   ## Brief change log
   
   - Add a note in "state.md" document.
   
   ## Verifying this change
   
   This change is a trivial work about document without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
     - Does this pull request introduce a new feature? no
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] masteryhx commented on a diff in pull request #23407: [FLINK-32953][docs]Add notes about changing state ttl value

Posted by "masteryhx (via GitHub)" <gi...@apache.org>.
masteryhx commented on code in PR #23407:
URL: https://github.com/apache/flink/pull/23407#discussion_r1326706374


##########
docs/content/docs/dev/datastream/fault-tolerance/state.md:
##########
@@ -429,6 +429,9 @@ will lead to compatibility failure and `StateMigrationException`.
 
 - The TTL configuration is not part of check- or savepoints but rather a way of how Flink treats it in the currently running job.
 
+- It is not recommended to restore checkpoint state with adjusting the ttl from a short value to a long value,

Review Comment:
   Thanks for the explaination. LGTM.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #23407: [FLINK-32953][docs]Add notes about changing state ttl value

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #23407:
URL: https://github.com/apache/flink/pull/23407#issuecomment-1717067773

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f59f7f7004c10ba16d2cdbb1dec363964414880c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f59f7f7004c10ba16d2cdbb1dec363964414880c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f59f7f7004c10ba16d2cdbb1dec363964414880c UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] masteryhx commented on a diff in pull request #23407: [FLINK-32953][docs]Add notes about changing state ttl value

Posted by "masteryhx (via GitHub)" <gi...@apache.org>.
masteryhx commented on code in PR #23407:
URL: https://github.com/apache/flink/pull/23407#discussion_r1324257482


##########
docs/content/docs/dev/datastream/fault-tolerance/state.md:
##########
@@ -429,6 +429,9 @@ will lead to compatibility failure and `StateMigrationException`.
 
 - The TTL configuration is not part of check- or savepoints but rather a way of how Flink treats it in the currently running job.
 
+- It is not recommended to restore checkpoint state with adjusting the ttl from a short value to a long value,

Review Comment:
   IIUC, It just affects RocksDBStateBackend instead of HashMapStateBackend, right ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] masteryhx closed pull request #23407: [FLINK-32953][docs]Add notes about changing state ttl value

Posted by "masteryhx (via GitHub)" <gi...@apache.org>.
masteryhx closed pull request #23407: [FLINK-32953][docs]Add notes about changing state ttl value
URL: https://github.com/apache/flink/pull/23407


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] ljz2051 commented on a diff in pull request #23407: [FLINK-32953][docs]Add notes about changing state ttl value

Posted by "ljz2051 (via GitHub)" <gi...@apache.org>.
ljz2051 commented on code in PR #23407:
URL: https://github.com/apache/flink/pull/23407#discussion_r1325298406


##########
docs/content/docs/dev/datastream/fault-tolerance/state.md:
##########
@@ -429,6 +429,9 @@ will lead to compatibility failure and `StateMigrationException`.
 
 - The TTL configuration is not part of check- or savepoints but rather a way of how Flink treats it in the currently running job.
 
+- It is not recommended to restore checkpoint state with adjusting the ttl from a short value to a long value,

Review Comment:
   As described in [jira](https://issues.apache.org/jira/browse/FLINK-32953), RocksDBStateBackend may exist data correctness problem. But both RocksDBStateBackend and HashMapStateBackend have issue with expired data becoming visible after restore. 
   So, I think this notes should take effect for both RocksDBStateBackend and HashMapStateBackend.
   WDYT?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org