[GitHub] [spark] viirya commented on a change in pull request #25965: [SPARK-26425][SS] Add more constraint checks to avoid checkpoint corruption

[GitBox <gi...@apache.org>]

viirya commented on a change in pull request #25965:
URL: https://github.com/apache/spark/pull/25965#discussion_r489180882



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/MicroBatchExecution.scala
##########
@@ -585,7 +585,8 @@ class MicroBatchExecution(
     withProgressLocked {
       sinkCommitProgress = batchSinkProgress
       watermarkTracker.updateWatermark(lastExecution.executedPlan)
-      commitLog.add(currentBatchId, CommitMetadata(watermarkTracker.currentWatermark))
+      assert(commitLog.add(currentBatchId, CommitMetadata(watermarkTracker.currentWatermark)),
+        s"Concurrent update to the log. Multiple streaming jobs detected for $currentBatchId")

Review comment:
       update to the log -> update to the commit log?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org