You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by Oleg Kalnichevski <ol...@apache.org> on 2019/02/05 14:39:34 UTC
HttpCore 5.0 BETA7?
Ryan et al
Would you like me to cut 5.0-beta7 this weekend or should you like to
be a release manager for this release?
Oleg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
Re: HttpCore 5.0 BETA7?
Posted by Ryan Schmitt <rs...@apache.org>.
Almost! My colleague has one more subtle bugfix to merge first:
https://github.com/apache/httpcomponents-core/pull/111
On Fri, Feb 22, 2019 at 11:31 AM Gary Gregory <ga...@gmail.com>
wrote:
> Let's fire up the new beta! :-)
>
> Gary
>
> On Sat, Feb 16, 2019, 09:26 Oleg Kalnichevski <olegk@apache.org wrote:
>
> > On Sat, 2019-02-16 at 09:18 -0500, Gary Gregory wrote:
> > >
> >
> > ...
> >
> > > I get a compiler error with the above patch:
> > >
> > > Description Resource Path Location Type
> > > The method
> > > setLookupRegistry(LookupRegistry<Supplier<AsyncServerExchangeHandler>
> > > >) in
> > > the type AsyncServerBootstrap is not applicable for the arguments
> > > (new
> > > LookupRegistry<AsyncServerExchangeHandler>(){})
> > > TestAsyncServerBootstrapLookupRegistry.java
> > > /httpcore5/src/test/java/org/apache/hc/core5/http/impl/bootstrap line
> > > 42 Java
> > > Problem
> > >
> > > Gary
> > >
> > >
> >
> >
> >
> >
> https://github.com/ok2c/httpcore/commit/8794a8b0617ac7e3bcf713fbab5314232a0410b8
> >
> > Oleg
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> > For additional commands, e-mail: dev-help@hc.apache.org
> >
> >
>
Re: HttpCore 5.0 BETA7?
Posted by Gary Gregory <ga...@gmail.com>.
Let's fire up the new beta! :-)
Gary
On Sat, Feb 16, 2019, 09:26 Oleg Kalnichevski <olegk@apache.org wrote:
> On Sat, 2019-02-16 at 09:18 -0500, Gary Gregory wrote:
> >
>
> ...
>
> > I get a compiler error with the above patch:
> >
> > Description Resource Path Location Type
> > The method
> > setLookupRegistry(LookupRegistry<Supplier<AsyncServerExchangeHandler>
> > >) in
> > the type AsyncServerBootstrap is not applicable for the arguments
> > (new
> > LookupRegistry<AsyncServerExchangeHandler>(){})
> > TestAsyncServerBootstrapLookupRegistry.java
> > /httpcore5/src/test/java/org/apache/hc/core5/http/impl/bootstrap line
> > 42 Java
> > Problem
> >
> > Gary
> >
> >
>
>
>
> https://github.com/ok2c/httpcore/commit/8794a8b0617ac7e3bcf713fbab5314232a0410b8
>
> Oleg
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> For additional commands, e-mail: dev-help@hc.apache.org
>
>
Re: HttpCore 5.0 BETA7?
Posted by Oleg Kalnichevski <ol...@apache.org>.
On Sat, 2019-02-16 at 09:18 -0500, Gary Gregory wrote:
>
...
> I get a compiler error with the above patch:
>
> Description Resource Path Location Type
> The method
> setLookupRegistry(LookupRegistry<Supplier<AsyncServerExchangeHandler>
> >) in
> the type AsyncServerBootstrap is not applicable for the arguments
> (new
> LookupRegistry<AsyncServerExchangeHandler>(){})
> TestAsyncServerBootstrapLookupRegistry.java
> /httpcore5/src/test/java/org/apache/hc/core5/http/impl/bootstrap line
> 42 Java
> Problem
>
> Gary
>
>
https://github.com/ok2c/httpcore/commit/8794a8b0617ac7e3bcf713fbab5314232a0410b8
Oleg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
Re: HttpCore 5.0 BETA7?
Posted by Gary Gregory <ga...@gmail.com>.
On Sat, Feb 16, 2019 at 9:11 AM Oleg Kalnichevski <ol...@apache.org> wrote:
> On Sat, 2019-02-16 at 08:45 -0500, Gary Gregory wrote:
> >
>
> ...
>
>
> > This is what Eclipse says for one of the call sites:
> >
> > Description Resource Path Location Type
> >
> > LookupRegistry is a raw type. References to generic type
> > LookupRegistry<T>
> > should be parameterized AsyncServerBootstrap.java
> > /httpcore5/src/main/java/org/apache/hc/core5/http/impl/bootstrap line
> > 334 Java
> > Problem
> >
> > Supplier is a raw type. References to generic type Supplier<T> should
> > be
> > parameterized AsyncServerBootstrap.java
> > /httpcore5/src/main/java/org/apache/hc/core5/http/impl/bootstrap line
> > 331 Java
> > Problem
> >
> > Type safety: The expression of type new Supplier(){} needs unchecked
> > conversion to conform to
> > Supplier<LookupRegistry<Supplier<AsyncServerExchangeHandler>>>
> > AsyncServerBootstrap.java
> > /httpcore5/src/main/java/org/apache/hc/core5/http/impl/bootstrap line
> > 331 Java
> > Problem
> >
> > Gary
> >
>
>
> Index:
> httpcore5/src/test/java/org/apache/hc/core5/http/impl/bootstrap/TestAsyncServerBootstrapLookupRegistry.java
> IDEA additional info:
> Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
> <+>UTF-8
> ===================================================================
> ---
> httpcore5/src/test/java/org/apache/hc/core5/http/impl/bootstrap/TestAsyncServerBootstrapLookupRegistry.java
> (revision e3b474456dda8b978f1a0eabdfa71e6e308a37cd)
> +++
> httpcore5/src/test/java/org/apache/hc/core5/http/impl/bootstrap/TestAsyncServerBootstrapLookupRegistry.java
> (date 1550326220000)
> @@ -26,6 +26,7 @@
> */
> package org.apache.hc.core5.http.impl.bootstrap;
>
> +import org.apache.hc.core5.function.Supplier;
> import org.apache.hc.core5.http.nio.AsyncServerExchangeHandler;
> import org.apache.hc.core5.http.protocol.LookupRegistry;
> import org.junit.Test;
> @@ -39,23 +40,21 @@
>
> @Test
> public void testCreateCustomLookupRegistry() {
> - AsyncServerBootstrap.bootstrap().setLookupRegistry(new
> LookupRegistry<AsyncServerExchangeHandler>() {
> + AsyncServerBootstrap.bootstrap().setLookupRegistry(new
> LookupRegistry<Supplier<AsyncServerExchangeHandler>>() {
>
> @Override
> - public void register(final String pattern, final
> AsyncServerExchangeHandler obj) {
> - // noop
> + public void register(String pattern,
> Supplier<AsyncServerExchangeHandler> obj) {
> }
>
> @Override
> - public AsyncServerExchangeHandler lookup(final String value) {
> - // noop
> + public Supplier<AsyncServerExchangeHandler> lookup(String
> value) {
> return null;
> }
>
> @Override
> - public void unregister(final String pattern) {
> - // noop
> + public void unregister(String pattern) {
> }
> +
> }).create();
> }
> }
> Index:
> httpcore5/src/main/java/org/apache/hc/core5/http/impl/bootstrap/AsyncServerBootstrap.java
> IDEA additional info:
> Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
> <+>UTF-8
> ===================================================================
> ---
> httpcore5/src/main/java/org/apache/hc/core5/http/impl/bootstrap/AsyncServerBootstrap.java
> (revision e3b474456dda8b978f1a0eabdfa71e6e308a37cd)
> +++
> httpcore5/src/main/java/org/apache/hc/core5/http/impl/bootstrap/AsyncServerBootstrap.java
> (date 1550326094000)
> @@ -77,7 +77,7 @@
> private final
> List<HandlerEntry<Supplier<AsyncServerExchangeHandler>>> handlerList;
> private final List<FilterEntry<AsyncFilterHandler>> filters;
> private String canonicalHostName;
> - private LookupRegistry<AsyncServerExchangeHandler> lookupRegistry;
> + private LookupRegistry<Supplier<AsyncServerExchangeHandler>>
> lookupRegistry;
> private IOReactorConfig ioReactorConfig;
> private H1Config h1Config;
> private CharCodingConfig charCodingConfig;
> @@ -184,7 +184,7 @@
> * @return this
> * @since 5.0
> */
> - public final AsyncServerBootstrap setLookupRegistry(final
> LookupRegistry<AsyncServerExchangeHandler> lookupRegistry) {
> + public final AsyncServerBootstrap setLookupRegistry(final
> LookupRegistry<Supplier<AsyncServerExchangeHandler>> lookupRegistry) {
> this.lookupRegistry = lookupRegistry;
> return this;
> }
> @@ -328,11 +328,12 @@
> public HttpAsyncServer create() {
> final
> RequestHandlerRegistry<Supplier<AsyncServerExchangeHandler>> registry = new
> RequestHandlerRegistry<>(
> canonicalHostName != null ? canonicalHostName :
> InetAddressUtils.getCanonicalLocalHostName(),
> - new Supplier() {
> + new
> Supplier<LookupRegistry<Supplier<AsyncServerExchangeHandler>>>() {
>
> @Override
> - public LookupRegistry get() {
> - return lookupRegistry != null ? lookupRegistry :
> UriPatternType.newMatcher(UriPatternType.URI_PATTERN);
> + public
> LookupRegistry<Supplier<AsyncServerExchangeHandler>> get() {
> + return lookupRegistry != null ? lookupRegistry :
> +
> UriPatternType.<Supplier<AsyncServerExchangeHandler>>newMatcher(UriPatternType.URI_PATTERN);
> }
>
> });
>
I get a compiler error with the above patch:
Description Resource Path Location Type
The method
setLookupRegistry(LookupRegistry<Supplier<AsyncServerExchangeHandler>>) in
the type AsyncServerBootstrap is not applicable for the arguments (new
LookupRegistry<AsyncServerExchangeHandler>(){})
TestAsyncServerBootstrapLookupRegistry.java
/httpcore5/src/test/java/org/apache/hc/core5/http/impl/bootstrap line 42 Java
Problem
Gary
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> For additional commands, e-mail: dev-help@hc.apache.org
>
>
Re: HttpCore 5.0 BETA7?
Posted by Oleg Kalnichevski <ol...@apache.org>.
On Sat, 2019-02-16 at 08:45 -0500, Gary Gregory wrote:
>
...
> This is what Eclipse says for one of the call sites:
>
> Description Resource Path Location Type
>
> LookupRegistry is a raw type. References to generic type
> LookupRegistry<T>
> should be parameterized AsyncServerBootstrap.java
> /httpcore5/src/main/java/org/apache/hc/core5/http/impl/bootstrap line
> 334 Java
> Problem
>
> Supplier is a raw type. References to generic type Supplier<T> should
> be
> parameterized AsyncServerBootstrap.java
> /httpcore5/src/main/java/org/apache/hc/core5/http/impl/bootstrap line
> 331 Java
> Problem
>
> Type safety: The expression of type new Supplier(){} needs unchecked
> conversion to conform to
> Supplier<LookupRegistry<Supplier<AsyncServerExchangeHandler>>>
> AsyncServerBootstrap.java
> /httpcore5/src/main/java/org/apache/hc/core5/http/impl/bootstrap line
> 331 Java
> Problem
>
> Gary
>
Index: httpcore5/src/test/java/org/apache/hc/core5/http/impl/bootstrap/TestAsyncServerBootstrapLookupRegistry.java
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- httpcore5/src/test/java/org/apache/hc/core5/http/impl/bootstrap/TestAsyncServerBootstrapLookupRegistry.java (revision e3b474456dda8b978f1a0eabdfa71e6e308a37cd)
+++ httpcore5/src/test/java/org/apache/hc/core5/http/impl/bootstrap/TestAsyncServerBootstrapLookupRegistry.java (date 1550326220000)
@@ -26,6 +26,7 @@
*/
package org.apache.hc.core5.http.impl.bootstrap;
+import org.apache.hc.core5.function.Supplier;
import org.apache.hc.core5.http.nio.AsyncServerExchangeHandler;
import org.apache.hc.core5.http.protocol.LookupRegistry;
import org.junit.Test;
@@ -39,23 +40,21 @@
@Test
public void testCreateCustomLookupRegistry() {
- AsyncServerBootstrap.bootstrap().setLookupRegistry(new LookupRegistry<AsyncServerExchangeHandler>() {
+ AsyncServerBootstrap.bootstrap().setLookupRegistry(new LookupRegistry<Supplier<AsyncServerExchangeHandler>>() {
@Override
- public void register(final String pattern, final AsyncServerExchangeHandler obj) {
- // noop
+ public void register(String pattern, Supplier<AsyncServerExchangeHandler> obj) {
}
@Override
- public AsyncServerExchangeHandler lookup(final String value) {
- // noop
+ public Supplier<AsyncServerExchangeHandler> lookup(String value) {
return null;
}
@Override
- public void unregister(final String pattern) {
- // noop
+ public void unregister(String pattern) {
}
+
}).create();
}
}
Index: httpcore5/src/main/java/org/apache/hc/core5/http/impl/bootstrap/AsyncServerBootstrap.java
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- httpcore5/src/main/java/org/apache/hc/core5/http/impl/bootstrap/AsyncServerBootstrap.java (revision e3b474456dda8b978f1a0eabdfa71e6e308a37cd)
+++ httpcore5/src/main/java/org/apache/hc/core5/http/impl/bootstrap/AsyncServerBootstrap.java (date 1550326094000)
@@ -77,7 +77,7 @@
private final List<HandlerEntry<Supplier<AsyncServerExchangeHandler>>> handlerList;
private final List<FilterEntry<AsyncFilterHandler>> filters;
private String canonicalHostName;
- private LookupRegistry<AsyncServerExchangeHandler> lookupRegistry;
+ private LookupRegistry<Supplier<AsyncServerExchangeHandler>> lookupRegistry;
private IOReactorConfig ioReactorConfig;
private H1Config h1Config;
private CharCodingConfig charCodingConfig;
@@ -184,7 +184,7 @@
* @return this
* @since 5.0
*/
- public final AsyncServerBootstrap setLookupRegistry(final LookupRegistry<AsyncServerExchangeHandler> lookupRegistry) {
+ public final AsyncServerBootstrap setLookupRegistry(final LookupRegistry<Supplier<AsyncServerExchangeHandler>> lookupRegistry) {
this.lookupRegistry = lookupRegistry;
return this;
}
@@ -328,11 +328,12 @@
public HttpAsyncServer create() {
final RequestHandlerRegistry<Supplier<AsyncServerExchangeHandler>> registry = new RequestHandlerRegistry<>(
canonicalHostName != null ? canonicalHostName : InetAddressUtils.getCanonicalLocalHostName(),
- new Supplier() {
+ new Supplier<LookupRegistry<Supplier<AsyncServerExchangeHandler>>>() {
@Override
- public LookupRegistry get() {
- return lookupRegistry != null ? lookupRegistry : UriPatternType.newMatcher(UriPatternType.URI_PATTERN);
+ public LookupRegistry<Supplier<AsyncServerExchangeHandler>> get() {
+ return lookupRegistry != null ? lookupRegistry :
+ UriPatternType.<Supplier<AsyncServerExchangeHandler>>newMatcher(UriPatternType.URI_PATTERN);
}
});
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
Re: HttpCore 5.0 BETA7?
Posted by Gary Gregory <ga...@gmail.com>.
On Fri, Feb 15, 2019 at 5:31 PM Oleg Kalnichevski <ol...@apache.org> wrote:
> On Fri, 2019-02-15 at 16:06 -0500, Gary Gregory wrote:
> > On Wed, Feb 6, 2019 at 7:49 PM Gary Gregory <ga...@gmail.com>
> > wrote:
> >
> > > Oleg and all:
> > >
> > > Would you please take a look
> > > at
> > > org.apache.hc.core5.http.impl.bootstrap.CustomAsyncServerBootstrap.
> > > createRequestHandlerRegistry()
> > > in the branch HTTPCORE-570.
> > >
> > > The TODO comment, I believe surfaces a mistake in our generic
> > > typing
> > > of RequestHandlerRegistry or at least that one ctor.
> > >
> > > IOW, why doesn't this compile in CustomAsyncServerBootstrap:
> > >
> > > Supplier<LookupRegistry<AsyncServerExchangeHandler>>
> > > supplier =
> > > new Supplier<LookupRegistry<AsyncServerExchangeHandler>>() {...};
> > > RequestHandlerRegistry<Supplier<AsyncServerExchangeHandler>
> > > >
> > > registry = new RequestHandlerRegistry<>(
> > > actualCanonicalHostName, supplier);
> > >
> > >
> >
> > Note the compiler warnings for callers
> > of
> > org.apache.hc.core5.http.protocol.RequestHandlerRegistry.RequestHandl
> > erRegistry(String,
> > Supplier<LookupRegistry<T>>)
> >
> > Gary
> >
>
> Hi Gary
>
> I see no warning neither in the IDE nor compiling with Maven
>
> [INFO] --- maven-compiler-plugin:3.8.0:compile (default-compile) @
> httpcore5 ---
> [INFO] Toolchain in maven-compiler-plugin: JDK[/opt/oracle-jdk-1.7.0]
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 472 source files to /home/oleg/src/
> apache.org/httpcomponents/httpcore-5.x/httpcore5/target/classes
> [WARNING] /home/oleg/src/
> apache.org/httpcomponents/httpcore-5.x/httpcore5/src/main/java/org/apache/hc/core5/reactor/ssl/SSLIOSession.java:[212,16]
> <http://apache.org/httpcomponents/httpcore-5.x/httpcore5/src/main/java/org/apache/hc/core5/reactor/ssl/SSLIOSession.java:%5B212,16%5D>
> [deprecation] lock() in IOSession has been deprecated
> [WARNING] /home/oleg/src/
> apache.org/httpcomponents/httpcore-5.x/httpcore5/src/main/java/org/apache/hc/core5/reactor/InternalDataChannel.java:[270,16]
> <http://apache.org/httpcomponents/httpcore-5.x/httpcore5/src/main/java/org/apache/hc/core5/reactor/InternalDataChannel.java:%5B270,16%5D>
> [deprecation] lock() in IOSession has been deprecated
> [WARNING] /home/oleg/src/
> apache.org/httpcomponents/httpcore-5.x/httpcore5/src/main/java/org/apache/hc/core5/reactor/IOSessionImpl.java:[93,16]
> <http://apache.org/httpcomponents/httpcore-5.x/httpcore5/src/main/java/org/apache/hc/core5/reactor/IOSessionImpl.java:%5B93,16%5D>
> [deprecation] lock() in IOSession has been deprecated
> [INFO]
>
>
This is what Eclipse says for one of the call sites:
Description Resource Path Location Type
LookupRegistry is a raw type. References to generic type LookupRegistry<T>
should be parameterized AsyncServerBootstrap.java
/httpcore5/src/main/java/org/apache/hc/core5/http/impl/bootstrap line 334 Java
Problem
Supplier is a raw type. References to generic type Supplier<T> should be
parameterized AsyncServerBootstrap.java
/httpcore5/src/main/java/org/apache/hc/core5/http/impl/bootstrap line 331 Java
Problem
Type safety: The expression of type new Supplier(){} needs unchecked
conversion to conform to
Supplier<LookupRegistry<Supplier<AsyncServerExchangeHandler>>>
AsyncServerBootstrap.java
/httpcore5/src/main/java/org/apache/hc/core5/http/impl/bootstrap line 331 Java
Problem
Gary
> Oleg
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> For additional commands, e-mail: dev-help@hc.apache.org
>
>
Re: HttpCore 5.0 BETA7?
Posted by Oleg Kalnichevski <ol...@apache.org>.
On Fri, 2019-02-15 at 16:06 -0500, Gary Gregory wrote:
> On Wed, Feb 6, 2019 at 7:49 PM Gary Gregory <ga...@gmail.com>
> wrote:
>
> > Oleg and all:
> >
> > Would you please take a look
> > at
> > org.apache.hc.core5.http.impl.bootstrap.CustomAsyncServerBootstrap.
> > createRequestHandlerRegistry()
> > in the branch HTTPCORE-570.
> >
> > The TODO comment, I believe surfaces a mistake in our generic
> > typing
> > of RequestHandlerRegistry or at least that one ctor.
> >
> > IOW, why doesn't this compile in CustomAsyncServerBootstrap:
> >
> > Supplier<LookupRegistry<AsyncServerExchangeHandler>>
> > supplier =
> > new Supplier<LookupRegistry<AsyncServerExchangeHandler>>() {...};
> > RequestHandlerRegistry<Supplier<AsyncServerExchangeHandler>
> > >
> > registry = new RequestHandlerRegistry<>(
> > actualCanonicalHostName, supplier);
> >
> >
>
> Note the compiler warnings for callers
> of
> org.apache.hc.core5.http.protocol.RequestHandlerRegistry.RequestHandl
> erRegistry(String,
> Supplier<LookupRegistry<T>>)
>
> Gary
>
Hi Gary
I see no warning neither in the IDE nor compiling with Maven
[INFO] --- maven-compiler-plugin:3.8.0:compile (default-compile) @ httpcore5 ---
[INFO] Toolchain in maven-compiler-plugin: JDK[/opt/oracle-jdk-1.7.0]
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 472 source files to /home/oleg/src/apache.org/httpcomponents/httpcore-5.x/httpcore5/target/classes
[WARNING] /home/oleg/src/apache.org/httpcomponents/httpcore-5.x/httpcore5/src/main/java/org/apache/hc/core5/reactor/ssl/SSLIOSession.java:[212,16] [deprecation] lock() in IOSession has been deprecated
[WARNING] /home/oleg/src/apache.org/httpcomponents/httpcore-5.x/httpcore5/src/main/java/org/apache/hc/core5/reactor/InternalDataChannel.java:[270,16] [deprecation] lock() in IOSession has been deprecated
[WARNING] /home/oleg/src/apache.org/httpcomponents/httpcore-5.x/httpcore5/src/main/java/org/apache/hc/core5/reactor/IOSessionImpl.java:[93,16] [deprecation] lock() in IOSession has been deprecated
[INFO]
Oleg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
Re: HttpCore 5.0 BETA7?
Posted by Gary Gregory <ga...@gmail.com>.
On Wed, Feb 6, 2019 at 7:49 PM Gary Gregory <ga...@gmail.com> wrote:
> Oleg and all:
>
> Would you please take a look
> at org.apache.hc.core5.http.impl.bootstrap.CustomAsyncServerBootstrap.createRequestHandlerRegistry()
> in the branch HTTPCORE-570.
>
> The TODO comment, I believe surfaces a mistake in our generic typing
> of RequestHandlerRegistry or at least that one ctor.
>
> IOW, why doesn't this compile in CustomAsyncServerBootstrap:
>
> Supplier<LookupRegistry<AsyncServerExchangeHandler>> supplier =
> new Supplier<LookupRegistry<AsyncServerExchangeHandler>>() {...};
> RequestHandlerRegistry<Supplier<AsyncServerExchangeHandler>>
> registry = new RequestHandlerRegistry<>(
> actualCanonicalHostName, supplier);
>
>
Note the compiler warnings for callers
of org.apache.hc.core5.http.protocol.RequestHandlerRegistry.RequestHandlerRegistry(String,
Supplier<LookupRegistry<T>>)
Gary
> Thank you,
> Gary
>
>
> On Wed, Feb 6, 2019 at 4:14 PM Gary Gregory <ga...@gmail.com>
> wrote:
>
>> Please see:
>> - https://issues.apache.org/jira/browse/HTTPCORE-569 and branch
>> HTTPCORE-569
>> - https://issues.apache.org/jira/browse/HTTPCORE-570 and branch
>> HTTPCORE-570
>> Gary
>>
>> On Wed, Feb 6, 2019 at 2:39 PM Gary Gregory <ga...@gmail.com>
>> wrote:
>>
>>> I have a new feature I'd like to discuss which I'd love to see in Beta
>>> 7, I am writing the Jira now which we can discuss in a sec...
>>>
>>> Gary
>>>
>>> On Tue, Feb 5, 2019 at 4:29 PM Ryan Schmitt <rs...@apache.org> wrote:
>>>
>>>> https://issues.apache.org/jira/browse/HTTPCORE-568
>>>>
>>>> On Tue, Feb 5, 2019 at 6:39 AM Oleg Kalnichevski <ol...@apache.org>
>>>> wrote:
>>>>
>>>> > Ryan et al
>>>> >
>>>> > Would you like me to cut 5.0-beta7 this weekend or should you like to
>>>> > be a release manager for this release?
>>>> >
>>>> > Oleg
>>>> >
>>>> >
>>>> >
>>>> > ---------------------------------------------------------------------
>>>> > To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
>>>> > For additional commands, e-mail: dev-help@hc.apache.org
>>>> >
>>>> >
>>>>
>>>
Re: HttpCore 5.0 BETA7?
Posted by Gary Gregory <ga...@gmail.com>.
Oleg and all:
Would you please take a look
at org.apache.hc.core5.http.impl.bootstrap.CustomAsyncServerBootstrap.createRequestHandlerRegistry()
in the branch HTTPCORE-570.
The TODO comment, I believe surfaces a mistake in our generic typing
of RequestHandlerRegistry or at least that one ctor.
IOW, why doesn't this compile in CustomAsyncServerBootstrap:
Supplier<LookupRegistry<AsyncServerExchangeHandler>> supplier = new
Supplier<LookupRegistry<AsyncServerExchangeHandler>>() {...};
RequestHandlerRegistry<Supplier<AsyncServerExchangeHandler>>
registry = new RequestHandlerRegistry<>(
actualCanonicalHostName, supplier);
Thank you,
Gary
On Wed, Feb 6, 2019 at 4:14 PM Gary Gregory <ga...@gmail.com> wrote:
> Please see:
> - https://issues.apache.org/jira/browse/HTTPCORE-569 and branch
> HTTPCORE-569
> - https://issues.apache.org/jira/browse/HTTPCORE-570 and branch
> HTTPCORE-570
> Gary
>
> On Wed, Feb 6, 2019 at 2:39 PM Gary Gregory <ga...@gmail.com>
> wrote:
>
>> I have a new feature I'd like to discuss which I'd love to see in Beta 7,
>> I am writing the Jira now which we can discuss in a sec...
>>
>> Gary
>>
>> On Tue, Feb 5, 2019 at 4:29 PM Ryan Schmitt <rs...@apache.org> wrote:
>>
>>> https://issues.apache.org/jira/browse/HTTPCORE-568
>>>
>>> On Tue, Feb 5, 2019 at 6:39 AM Oleg Kalnichevski <ol...@apache.org>
>>> wrote:
>>>
>>> > Ryan et al
>>> >
>>> > Would you like me to cut 5.0-beta7 this weekend or should you like to
>>> > be a release manager for this release?
>>> >
>>> > Oleg
>>> >
>>> >
>>> >
>>> > ---------------------------------------------------------------------
>>> > To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
>>> > For additional commands, e-mail: dev-help@hc.apache.org
>>> >
>>> >
>>>
>>
Re: HttpCore 5.0 BETA7?
Posted by Gary Gregory <ga...@gmail.com>.
Please see:
- https://issues.apache.org/jira/browse/HTTPCORE-569 and branch HTTPCORE-569
- https://issues.apache.org/jira/browse/HTTPCORE-570 and branch HTTPCORE-570
Gary
On Wed, Feb 6, 2019 at 2:39 PM Gary Gregory <ga...@gmail.com> wrote:
> I have a new feature I'd like to discuss which I'd love to see in Beta 7,
> I am writing the Jira now which we can discuss in a sec...
>
> Gary
>
> On Tue, Feb 5, 2019 at 4:29 PM Ryan Schmitt <rs...@apache.org> wrote:
>
>> https://issues.apache.org/jira/browse/HTTPCORE-568
>>
>> On Tue, Feb 5, 2019 at 6:39 AM Oleg Kalnichevski <ol...@apache.org>
>> wrote:
>>
>> > Ryan et al
>> >
>> > Would you like me to cut 5.0-beta7 this weekend or should you like to
>> > be a release manager for this release?
>> >
>> > Oleg
>> >
>> >
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
>> > For additional commands, e-mail: dev-help@hc.apache.org
>> >
>> >
>>
>
Re: HttpCore 5.0 BETA7?
Posted by Gary Gregory <ga...@gmail.com>.
I have a new feature I'd like to discuss which I'd love to see in Beta 7, I
am writing the Jira now which we can discuss in a sec...
Gary
On Tue, Feb 5, 2019 at 4:29 PM Ryan Schmitt <rs...@apache.org> wrote:
> https://issues.apache.org/jira/browse/HTTPCORE-568
>
> On Tue, Feb 5, 2019 at 6:39 AM Oleg Kalnichevski <ol...@apache.org> wrote:
>
> > Ryan et al
> >
> > Would you like me to cut 5.0-beta7 this weekend or should you like to
> > be a release manager for this release?
> >
> > Oleg
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> > For additional commands, e-mail: dev-help@hc.apache.org
> >
> >
>
Re: HttpCore 5.0 BETA7?
Posted by Ryan Schmitt <rs...@apache.org>.
https://issues.apache.org/jira/browse/HTTPCORE-568
On Tue, Feb 5, 2019 at 6:39 AM Oleg Kalnichevski <ol...@apache.org> wrote:
> Ryan et al
>
> Would you like me to cut 5.0-beta7 this weekend or should you like to
> be a release manager for this release?
>
> Oleg
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> For additional commands, e-mail: dev-help@hc.apache.org
>
>
Re: HttpCore 5.0 BETA7?
Posted by Ryan Schmitt <rs...@apache.org>.
A member of my team has discovered a regression in beta6. I'll try to get
you a bug report today. This regression is a blocker, at least for our own
adoption and testing, so I'd like to fix it for beta7.
On Tue, Feb 5, 2019 at 6:39 AM Oleg Kalnichevski <ol...@apache.org> wrote:
> Ryan et al
>
> Would you like me to cut 5.0-beta7 this weekend or should you like to
> be a release manager for this release?
>
> Oleg
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> For additional commands, e-mail: dev-help@hc.apache.org
>
>