[PR] Pipe: Added metrics for receiver request size [iotdb]

["Caideyipi (via GitHub)" <gi...@apache.org>]

Caideyipi opened a new pull request, #15807:
URL: https://github.com/apache/iotdb/pull/15807

   ## Description
   As the title said.
   
   <!--
   In each section, please describe design decisions made, including:
    - Choice of algorithms
    - Behavioral aspects. What configuration values are acceptable? How are corner cases and error 
       conditions handled, such as when there are insufficient resources?
    - Class organization and design (how the logic is split between classes, inheritance, composition, 
       design patterns)
    - Method organization and design (how the logic is split between methods, parameters and return types)
    - Naming (class, method, API, configuration, HTTP endpoint, names of emitted metrics)
   -->
   
   
   <!-- It's good to describe an alternative design (or mention an alternative name) for every design 
   (or naming) decision point and compare the alternatives with the designs that you've implemented 
   (or the names you've chosen) to highlight the advantages of the chosen designs and names. -->
   
   <!-- If there was a discussion of the design of the feature implemented in this PR elsewhere 
   (e. g. a "Proposal" issue, any other issue, or a thread in the development mailing list), 
   link to that discussion from this PR description and explain what have changed in your final design 
   compared to your original proposal or the consensus version in the end of the discussion. 
   If something hasn't changed since the original discussion, you can omit a detailed discussion of 
   those aspects of the design here, perhaps apart from brief mentioning for the sake of readability 
   of this PR description. -->
   
   <!-- Some of the aspects mentioned above may be omitted for simple and small changes. -->
   
   <hr>
   
   This PR has:
   - [ ] been self-reviewed.
       - [ ] concurrent read
       - [ ] concurrent write
       - [ ] concurrent read and write 
   - [ ] added documentation for new or modified features or behaviors.
   - [ ] added Javadocs for most classes and all non-trivial methods. 
   - [ ] added or updated version, __license__, or notice information
   - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious 
     for an unfamiliar reader.
   - [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold 
     for code coverage.
   - [ ] added integration tests.
   - [ ] been tested in a test IoTDB cluster.
   
   <!-- Check the items by putting "x" in the brackets for the done things. Not all of these items 
   apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items 
   from the checklist above are strictly necessary, but it would be very helpful if you at least 
   self-review the PR. -->
   
   <hr>
   
   ##### Key changed/added classes (or packages if there are too many classes) in this PR
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Pipe: Added metrics for receiver request size [iotdb]

["Caideyipi (via GitHub)" <gi...@apache.org>]

Caideyipi commented on code in PR #15807:
URL: https://github.com/apache/iotdb/pull/15807#discussion_r4376807047


##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/metric/receiver/PipeDataNodeReceiverMetrics.java:
##########
@@ -472,6 +757,148 @@ private void unbind(final AbstractMetricService metricService) {
         RECEIVER,
         Tag.TYPE.toString(),
         "transferSlice");
+
+    // Rate
+    metricService.remove(
+        MetricType.RATE,
+        Metric.PIPE_DATANODE_RECEIVER_REQ_SIZE.toString(),
+        Tag.NAME.toString(),
+        RECEIVER,
+        Tag.TYPE.toString(),
+        "handshakeDatanodeV1");

Review Comment:
   [P2] Remove the same handshake tags that bindTo() registers. The rates are created with handshakeDataNodeV1/handshakeDataNodeV2, but removal uses handshakeDatanodeV1/handshakeDatanodeV2. Metric labels are case-sensitive, so both registered rates survive unbinding and retain their previous counts on rebinding. Use the registered spelling for both removals and cover the bind/unbind lifecycle.



##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/receiver/protocol/thrift/IoTDBDataNodeReceiver.java:
##########
@@ -247,8 +248,8 @@ public synchronized TPipeTransferResp receive(final TPipeTransferReq req) {
                         PipeTransferDataNodeHandshakeV1Req.fromTPipeTransferReq(req)),
                     req);
               } finally {
-                PipeDataNodeReceiverMetrics.getInstance()
-                    .recordHandshakeDatanodeV1Timer(System.nanoTime() - startTime);
+                metrics.recordHandshakeDatanodeV1Timer(System.nanoTime() - startTime);
+                metrics.markHandshakeDatanodeV1Size(req.body.limit());

Review Comment:
   [P2] Snapshot the readable body size before dispatch. A request body can be a ByteBuffer with a nonzero position (for example, a binary field backed by a Thrift transport buffer). limit() includes the bytes before that position, so these rates overcount request bytes. Reading the buffer after the handler also makes the result depend on parsing or getBody() normalizing it. Capture body == null ? 0 : body.remaining() once before parsing and use that value in every finally block in both receivers.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Pipe: Added metrics for receiver request size [iotdb]

["Caideyipi (via GitHub)" <gi...@apache.org>]

Caideyipi commented on PR #15807:
URL: https://github.com/apache/iotdb/pull/15807#issuecomment-6416100584

   Self-review passed after fixing two issues in 4601900bfab.
   
   - Capture the readable request body size before dispatch in both receivers, so buffer prefixes are excluded and parsing cannot change the byte count.
   - Use the registered DataNode handshake labels when removing request-size rates, so unbinding removes the metrics and rebinding starts with fresh counts.
   
   Added regression coverage for prefixed read-only buffers, GZIP request accounting, and metric unbinding/rebinding.
   
   Validation:
   - Spotless apply with `with-integration-tests`: passed.
   - Clean-source build of the matching TsFile dependencies and the affected 29-module IoTDB reactor on JDK 17: passed.
   - Focused unit tests (`PipeDataNodeReceiverMetricsTest` and `IoTDBDataNodeReceiverMetricsTest`): **3 passed, 0 failures, 0 errors, 0 skipped**.
   - GitHub CI is still running.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org