You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/12/19 19:30:12 UTC
[GitHub] [airflow] maxdml opened a new issue, #28474: varimport payloads are not logged in audit logs
maxdml opened a new issue, #28474:
URL: https://github.com/apache/airflow/issues/28474
### Description
The content of the payload of the /variable/varimport is not reported to audit logs.
### Use case/motivation
We should audit this payload in the same way we audit creating/updating/deleting individual variables through the UI
### Related issues
_No response_
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] amoghrajesh commented on issue #28474: varimport payloads are not logged in audit logs
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on issue #28474:
URL: https://github.com/apache/airflow/issues/28474#issuecomment-1563840823
@maxdml @potiuk this looks like an interesting issue for me to take up if no one is working on it actively.
New to audit side of things, do we have any docs on how to configure audit logs for an API?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed issue #28474: varimport payloads are not logged in audit logs
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk closed issue #28474: varimport payloads are not logged in audit logs
URL: https://github.com/apache/airflow/issues/28474
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on issue #28474: varimport payloads are not logged in audit logs
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #28474:
URL: https://github.com/apache/airflow/issues/28474#issuecomment-1358152338
Thanks for opening your first issue here! Be sure to follow the issue template!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] amoghrajesh commented on issue #28474: varimport payloads are not logged in audit logs
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on issue #28474:
URL: https://github.com/apache/airflow/issues/28474#issuecomment-1584651948
Where would be the best place to look for some examples? I am pretty new to this side, but want to explore more
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #28474: varimport payloads are not logged in audit logs
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #28474:
URL: https://github.com/apache/airflow/issues/28474#issuecomment-1583298279
no docs. just code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] amoghrajesh commented on issue #28474: varimport payloads are not logged in audit logs
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on issue #28474:
URL: https://github.com/apache/airflow/issues/28474#issuecomment-1627712390
IMO, we should close this issue as completed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #28474: varimport payloads are not logged in audit logs
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #28474:
URL: https://github.com/apache/airflow/issues/28474#issuecomment-1627626730
There is a "log" table. (Log class).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #28474: varimport payloads are not logged in audit logs
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #28474:
URL: https://github.com/apache/airflow/issues/28474#issuecomment-1627722807
Thanks @amoghrajesh . Closing. We can always re-open if the author will find still not fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] amoghrajesh commented on issue #28474: varimport payloads are not logged in audit logs
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on issue #28474:
URL: https://github.com/apache/airflow/issues/28474#issuecomment-1627712302
@potiuk @maxdml this issue has been fixed already. Verified that it is not an active issue anymore.
Observe the screenshot below:
Seems that is was fixed by #24079
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] amoghrajesh commented on issue #28474: varimport payloads are not logged in audit logs
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on issue #28474:
URL: https://github.com/apache/airflow/issues/28474#issuecomment-1627613659
@potiuk how are events added for audit logging in airflow. I am trying to find some docs or code for this but seeming to be lost. Any pointer to look for would be nice here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org