You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jena.apache.org by GitBox <gi...@apache.org> on 2022/09/03 05:57:16 UTC

[GitHub] [jena-site] ieugen opened a new pull request, #117: Improved backup docs https://github.com/apache/jena/issues/1500

ieugen opened a new pull request, #117:
URL: https://github.com/apache/jena-site/pull/117

   Signed-off-by: Eugen Stan <ie...@apache.org>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [jena-site] afs commented on a diff in pull request #117: Improved backup docs https://github.com/apache/jena/issues/1500

Posted by GitBox <gi...@apache.org>.
afs commented on code in PR #117:
URL: https://github.com/apache/jena-site/pull/117#discussion_r965076213


##########
source/documentation/tdb2/tdb2_admin.md:
##########
@@ -67,3 +67,13 @@ continue to be serviced.
 
 There is also a command line tool `tdb2.tdbbackup` to run the
 backup process on a database not in use.
+

Review Comment:
   `tdb2.tdbbackup` has had this feature for a long time. `tdb2.tdbbackup` isn't really very important. Nowadays, tarsnaction handling applies to all databases so special casing it isn't necessary. TBH It should probably be removed.
   
   The recent PR put the same functionality into Fuseki - they don't share code.
   
   The Fuseki code isworks with any database type, integrates into the Fuseki lifecycle and Fuseki logging.
   
   Could you put this change in the Fuseki docs please?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [jena-site] ieugen commented on pull request #117: Improved backup docs https://github.com/apache/jena/issues/1500

Posted by GitBox <gi...@apache.org>.
ieugen commented on PR #117:
URL: https://github.com/apache/jena-site/pull/117#issuecomment-1249539957

   > (separately we're discussing changing the publication pipeline to have a branch for future changes; we only have a per-PR staging at the moment). 
   
   This sounds great. Thanks.
   p.s. I did not have time to work on the backup stuff, plan to do that this year.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [jena-site] ieugen commented on a diff in pull request #117: Improved backup docs https://github.com/apache/jena/issues/1500

Posted by GitBox <gi...@apache.org>.
ieugen commented on code in PR #117:
URL: https://github.com/apache/jena-site/pull/117#discussion_r967691017


##########
source/documentation/tdb2/tdb2_admin.md:
##########
@@ -67,3 +67,13 @@ continue to be serviced.
 
 There is also a command line tool `tdb2.tdbbackup` to run the
 backup process on a database not in use.
+

Review Comment:
   I am a bit confused. 
   You want me to drop this PR and put the same text in fuseki docs here: https://github.com/apache/jena-site/blob/main/source/documentation/fuseki2/fuseki-server-protocol.md ? 
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [jena-site] ieugen commented on pull request #117: Improved backup docs https://github.com/apache/jena/issues/1500

Posted by GitBox <gi...@apache.org>.
ieugen commented on PR #117:
URL: https://github.com/apache/jena-site/pull/117#issuecomment-1245123615

   done.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [jena-site] afs commented on a diff in pull request #117: Improved backup docs https://github.com/apache/jena/issues/1500

Posted by GitBox <gi...@apache.org>.
afs commented on code in PR #117:
URL: https://github.com/apache/jena-site/pull/117#discussion_r968188010


##########
source/documentation/tdb2/tdb2_admin.md:
##########
@@ -67,3 +67,13 @@ continue to be serviced.
 
 There is also a command line tool `tdb2.tdbbackup` to run the
 backup process on a database not in use.
+

Review Comment:
   Yes please.
   (either drop this PR or rebase the changes on top of it)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [jena-site] afs commented on pull request #117: Improved backup docs https://github.com/apache/jena/issues/1500

Posted by GitBox <gi...@apache.org>.
afs commented on PR #117:
URL: https://github.com/apache/jena-site/pull/117#issuecomment-1249349319

   Thanks! Looks good.
   
   Because this refers to 4.7.0, it won't get merged to main just yet.
   
   (separately we're discussing changing the publication pipeline to have a branch for future changes; we only have a per-PR staging at the moment).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [jena-site] afs merged pull request #117: Improved backup docs https://github.com/apache/jena/issues/1500

Posted by GitBox <gi...@apache.org>.
afs merged PR #117:
URL: https://github.com/apache/jena-site/pull/117


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org