[GitHub] [arrow-datafusion] liukun4515 commented on a diff in pull request #5156: Always wrapping OnceAsync for the inner table side in NestedLoopJoinExec

["liukun4515 (via GitHub)" <gi...@apache.org>]

liukun4515 commented on code in PR #5156:
URL: https://github.com/apache/arrow-datafusion/pull/5156#discussion_r1098307031


##########
datafusion/core/tests/sql/joins.rs:
##########
@@ -3298,3 +3298,105 @@ async fn two_in_subquery_to_join_with_outer_filter() -> Result<()> {
 
     Ok(())
 }
+
+#[tokio::test]
+async fn right_as_inner_table_nested_loop_join() -> Result<()> {
+    let ctx = create_nested_loop_join_context()?;
+
+    let sql = "SELECT t1.t1_id, t2.t2_id 

Review Comment:
   can we add comments to display the distribution required by the join type, like below
   
   ```
   // Distribution: left is `UnspecifiedDistribution`, right is `SinglePartition`
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org