[GitHub] [druid] FrankChen021 commented on pull request #11127: Set default value of ZK_VERSION in docker compose file

[GitBox <gi...@apache.org>]

FrankChen021 commented on pull request #11127:
URL: https://github.com/apache/druid/pull/11127#issuecomment-822916944


   > thanks @FrankChen021 I'm actually planning to remove the need for this environment variable in #11073. Since we want to keep the maven ZK version in sync with what we run integration tests against, we may need to adjust things a little.
   
   Thanks for you information. I checked the PR you mentioned, and found that there's no change made to `integration-tests/docker/service-supervisords/zookeeper.conf` which references `ZK_VERSION` environment variable. That means setting of this env variable is still needed before manually executing 'docker-compose' command to bring up Druid cluster. The core change in this PR is setting this environment variable in docker file instead of pom.xml in integration-test module. Do you plan to make an adjust there ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org