Re: [PR] feat: cleanup & simplify ballista config [datafusion-ballista]

["andygrove (via GitHub)" <gi...@apache.org>]

andygrove commented on code in PR #2387:
URL: https://github.com/apache/datafusion-ballista/pull/2387#discussion_r3896356205


##########
ballista/core/src/config.rs:
##########
@@ -746,8 +752,8 @@ impl BallistaConfig {
 
     /// Returns the target post-coalesce partition byte size in bytes
     /// (Spark's `advisoryPartitionSizeInBytes`).
-    pub fn coalesce_target_partition_bytes(&self) -> u64 {
-        self.get_usize_setting(BALLISTA_COALESCE_TARGET_PARTITION_BYTES) as u64
+    pub fn coalesce_target_partition_bytes(&self) -> usize {

Review Comment:
   I think keeping `usize` is more consistent with upstream DataFusion



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org