You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "dbalek (via GitHub)" <gi...@apache.org> on 2023/06/21 12:16:19 UTC
[GitHub] [netbeans] dbalek opened a new pull request, #6107: Dbalek/micronaut class generator fixes
dbalek opened a new pull request, #6107:
URL: https://github.com/apache/netbeans/pull/6107
Fixing generator of Micronaut entity classes and repositories for the case that entities need PK classes to be generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] dbalek merged pull request #6107: Dbalek/micronaut class generator fixes
Posted by "dbalek (via GitHub)" <gi...@apache.org>.
dbalek merged PR #6107:
URL: https://github.com/apache/netbeans/pull/6107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] dbalek commented on a diff in pull request #6107: Dbalek/micronaut class generator fixes
Posted by "dbalek (via GitHub)" <gi...@apache.org>.
dbalek commented on code in PR #6107:
URL: https://github.com/apache/netbeans/pull/6107#discussion_r1243276372
##########
enterprise/micronaut/src/org/netbeans/modules/micronaut/db/MicronautEntity.java:
##########
@@ -473,8 +540,13 @@ protected Property createProperty(EntityMember m) throws IOException {
}
}
- if (!columnAnnArguments.isEmpty() && generateJPA) {
- annotations.add(genUtils.createAnnotation("javax.persistence.Column", columnAnnArguments)); //NOI18N
+ if (!columnAnnArguments.isEmpty()) {
+ if (generateJPA) {
+ annotations.add(genUtils.createAnnotation("javax.persistence.Column", columnAnnArguments)); //NOI18N
+ }
+ if (isPKMember && needsPKClass && jakartaSupported) {
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] jhorvath commented on a diff in pull request #6107: Dbalek/micronaut class generator fixes
Posted by "jhorvath (via GitHub)" <gi...@apache.org>.
jhorvath commented on code in PR #6107:
URL: https://github.com/apache/netbeans/pull/6107#discussion_r1241970413
##########
enterprise/micronaut/src/org/netbeans/modules/micronaut/db/MicronautEntity.java:
##########
@@ -473,8 +540,13 @@ protected Property createProperty(EntityMember m) throws IOException {
}
}
- if (!columnAnnArguments.isEmpty() && generateJPA) {
- annotations.add(genUtils.createAnnotation("javax.persistence.Column", columnAnnArguments)); //NOI18N
+ if (!columnAnnArguments.isEmpty()) {
+ if (generateJPA) {
+ annotations.add(genUtils.createAnnotation("javax.persistence.Column", columnAnnArguments)); //NOI18N
+ }
+ if (isPKMember && needsPKClass && jakartaSupported) {
Review Comment:
If isPKMember and needsPKClass is true and jakartaSupported false, generated is not valid. Jakarta annotations are needed for PK class. Generation should fail in this case and user should be notified to add jakarta.persistence to the project
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists