[GitHub] astahlman commented on a change in pull request #4658: [WIP] [AIRFLOW-3813] Add CLI commands to manage roles

[GitBox <gi...@apache.org>]

astahlman commented on a change in pull request #4658: [WIP] [AIRFLOW-3813] Add CLI commands to manage roles
URL: https://github.com/apache/airflow/pull/4658#discussion_r254465553
 
 

 ##########
 File path: airflow/www/security.py
 ##########
 @@ -195,6 +195,19 @@ def init_role(self, role_name, role_vms, role_perms):
         else:
             self.log.info('Existing permissions for the role:%s within the database will persist.', role_name)
 
+    def delete_role(self, role_name):
 
 Review comment:
   Yeah, it doesn't appear to. These are the methods it does have:
   
   ```
       """
       ----------------------
        PRIMITIVES FOR ROLES
       ----------------------
       """
       def find_role(self, name):
           raise NotImplementedError
   
       def add_role(self, name):
           raise NotImplementedError
   
       def get_all_roles(self):
           raise NotImplementedError
   ```
   
   From https://flask-appbuilder.readthedocs.io/en/latest/_modules/flask_appbuilder/security/manager.html

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services