You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/29 19:04:33 UTC

[GitHub] [flink] ayushtkn opened a new pull request #10966: FLINK-15740. Remove Deadline#timeLeft().

ayushtkn opened a new pull request #10966: FLINK-15740. Remove Deadline#timeLeft().
URL: https://github.com/apache/flink/pull/10966
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10966: FLINK-15740. Remove Deadline#timeLeft().

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10966: FLINK-15740. Remove Deadline#timeLeft().
URL: https://github.com/apache/flink/pull/10966#issuecomment-579910536
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit af6ca7d14c5fe80360b195ef0c8df6a0f7eb2678 (Wed Jan 29 19:06:34 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-15740).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zentol closed pull request #10966: FLINK-15740. Remove Deadline#timeLeft().

Posted by GitBox <gi...@apache.org>.
zentol closed pull request #10966: FLINK-15740. Remove Deadline#timeLeft().
URL: https://github.com/apache/flink/pull/10966
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10966: FLINK-15740. Remove Deadline#timeLeft().

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10966: FLINK-15740. Remove Deadline#timeLeft().
URL: https://github.com/apache/flink/pull/10966#issuecomment-579929854
 
 
   <!--
   Meta data
   Hash:af6ca7d14c5fe80360b195ef0c8df6a0f7eb2678 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:af6ca7d14c5fe80360b195ef0c8df6a0f7eb2678
   -->
   ## CI report:
   
   * af6ca7d14c5fe80360b195ef0c8df6a0f7eb2678 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] ayushtkn commented on issue #10966: FLINK-15740. Remove Deadline#timeLeft().

Posted by GitBox <gi...@apache.org>.
ayushtkn commented on issue #10966: FLINK-15740. Remove Deadline#timeLeft().
URL: https://github.com/apache/flink/pull/10966#issuecomment-579958721
 
 
   @zentol I checked the descroption, if I eliminate the use of hasTimeLeft() and switch to timeLeftIfAny() in bunch of cases it would lead to unnecessary evaluations. And If I use hasTimeLeft() so what time to wait instead timeLeftIfAny()?
   To counter this only I used both together, I thought intent is to prevent negative value from being passed, seems the intent is something else?
   
   *Apologies for checkstyles, I thought all Apache projects have same rules, so assumed it would go same here, which wasn't the case. :( 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10966: FLINK-15740. Remove Deadline#timeLeft().

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10966: FLINK-15740. Remove Deadline#timeLeft().
URL: https://github.com/apache/flink/pull/10966#issuecomment-579929854
 
 
   <!--
   Meta data
   Hash:af6ca7d14c5fe80360b195ef0c8df6a0f7eb2678 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146652328 TriggerType:PUSH TriggerID:af6ca7d14c5fe80360b195ef0c8df6a0f7eb2678
   Hash:af6ca7d14c5fe80360b195ef0c8df6a0f7eb2678 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4663 TriggerType:PUSH TriggerID:af6ca7d14c5fe80360b195ef0c8df6a0f7eb2678
   -->
   ## CI report:
   
   * af6ca7d14c5fe80360b195ef0c8df6a0f7eb2678 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146652328) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4663) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zentol commented on issue #10966: FLINK-15740. Remove Deadline#timeLeft().

Posted by GitBox <gi...@apache.org>.
zentol commented on issue #10966: FLINK-15740. Remove Deadline#timeLeft().
URL: https://github.com/apache/flink/pull/10966#issuecomment-579951423
 
 
   CI is failing due to checkstyle violations, and _literally_ every single line was modified incorrectly.
   The JIRA description was very specific on how existing usages should be changed. Please read the description again, try to understand the underlying problem, and have another go at it.
   (hint: if you use `timeleftIfAny()`, you shouldn't use `hasTimeLeft()` in a surrounding condition)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services