You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/23 01:26:03 UTC
[GitHub] [flink] zentol commented on a change in pull request #13749: [FLINK-19712][Coordination] Do not restart CREATED executions in RestartPipelinedRegionFailoverStrategy
zentol commented on a change in pull request #13749:
URL: https://github.com/apache/flink/pull/13749#discussion_r510545111
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/strategy/TestingSchedulingTopology.java
##########
@@ -350,12 +352,21 @@ public SchedulingExecutionVerticesBuilder withInputDependencyConstraint(final In
public List<TestingSchedulingExecutionVertex> finish() {
final List<TestingSchedulingExecutionVertex> vertices = new ArrayList<>();
for (int subtaskIndex = 0; subtaskIndex < parallelism; subtaskIndex++) {
- vertices.add(new TestingSchedulingExecutionVertex(jobVertexId, subtaskIndex, inputDependencyConstraint));
+ vertices.add(createTestingSchedulingExecutionVertex(subtaskIndex));
}
TestingSchedulingTopology.this.addSchedulingExecutionVertices(vertices);
return vertices;
}
+
+ private TestingSchedulingExecutionVertex createTestingSchedulingExecutionVertex(
+ final int subtaskIndex) {
Review comment:
This wrapping caused by the updated .editorconfig is seriously annoying 💢
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org