You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "iajoiner (via GitHub)" <gi...@apache.org> on 2023/02/27 02:25:09 UTC
[GitHub] [arrow-datafusion-python] iajoiner opened a new pull request, #247: Fix broken mac win action
iajoiner opened a new pull request, #247:
URL: https://github.com/apache/arrow-datafusion-python/pull/247
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #211.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] cpcloud commented on pull request #247: Fix broken mac win manylinux action
Posted by "cpcloud (via GitHub)" <gi...@apache.org>.
cpcloud commented on PR #247:
URL: https://github.com/apache/arrow-datafusion-python/pull/247#issuecomment-1453630028
@iajoiner Can you try setting `PROTOC=path/to/bin/protoc`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] andygrove commented on pull request #247: Fix broken mac win manylinux action
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on PR #247:
URL: https://github.com/apache/arrow-datafusion-python/pull/247#issuecomment-1496120220
Thanks for the help with this. The release build is now passing again, based on this work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] cpcloud commented on a diff in pull request #247: Fix broken mac win manylinux action
Posted by "cpcloud (via GitHub)" <gi...@apache.org>.
cpcloud commented on code in PR #247:
URL: https://github.com/apache/arrow-datafusion-python/pull/247#discussion_r1118984419
##########
.github/workflows/build.yml:
##########
@@ -97,19 +112,25 @@ jobs:
name: python-wheel-license
path: .
- run: cat LICENSE.txt
+ - name: Install Protoc
+ uses: arduino/setup-protoc@v1
+ with:
+ version: '3.x'
+ repo-token: ${{ secrets.GITHUB_TOKEN }}
Review Comment:
This is already being installed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] iajoiner commented on pull request #247: Fix broken mac win manylinux action
Posted by "iajoiner (via GitHub)" <gi...@apache.org>.
iajoiner commented on PR #247:
URL: https://github.com/apache/arrow-datafusion-python/pull/247#issuecomment-1445578955
@andygrove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] cpcloud commented on pull request #247: Fix broken mac win manylinux action
Posted by "cpcloud (via GitHub)" <gi...@apache.org>.
cpcloud commented on PR #247:
URL: https://github.com/apache/arrow-datafusion-python/pull/247#issuecomment-1458208287
Ok. I don't really have the time to spend on making this work right now. I am happy to review and merge PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] andygrove closed pull request #247: Fix broken mac win manylinux action
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove closed pull request #247: Fix broken mac win manylinux action
URL: https://github.com/apache/arrow-datafusion-python/pull/247
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] cpcloud commented on a diff in pull request #247: Fix broken mac win manylinux action
Posted by "cpcloud (via GitHub)" <gi...@apache.org>.
cpcloud commented on code in PR #247:
URL: https://github.com/apache/arrow-datafusion-python/pull/247#discussion_r1118983990
##########
.github/workflows/build.yml:
##########
@@ -97,19 +112,25 @@ jobs:
name: python-wheel-license
path: .
- run: cat LICENSE.txt
+ - name: Install Protoc
+ uses: arduino/setup-protoc@v1
+ with:
+ version: '3.x'
+ repo-token: ${{ secrets.GITHUB_TOKEN }}
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] mbrobbel commented on pull request #247: Fix broken mac win manylinux action
Posted by "mbrobbel (via GitHub)" <gi...@apache.org>.
mbrobbel commented on PR #247:
URL: https://github.com/apache/arrow-datafusion-python/pull/247#issuecomment-1458246360
We can also use the `before-script-linux` to install `protoc`: https://github.com/PyO3/maturin-action/blob/126798b090fbe85aa20bfbecd8710f2697d4d3f4/.github/workflows/test.yml#L55-L57
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] andygrove commented on pull request #247: Fix broken mac win manylinux action
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on PR #247:
URL: https://github.com/apache/arrow-datafusion-python/pull/247#issuecomment-1468185550
Sorry for the delay in getting to this. I would like to cut the next RC this Friday, so would like to help get these issues resolved. What is the next step ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] iajoiner commented on pull request #247: Fix broken mac win manylinux action
Posted by "iajoiner (via GitHub)" <gi...@apache.org>.
iajoiner commented on PR #247:
URL: https://github.com/apache/arrow-datafusion-python/pull/247#issuecomment-1472027042
@andygrove protoc somehow doesn’t get found in two pipelines..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] mbrobbel commented on pull request #247: Fix broken mac win manylinux action
Posted by "mbrobbel (via GitHub)" <gi...@apache.org>.
mbrobbel commented on PR #247:
URL: https://github.com/apache/arrow-datafusion-python/pull/247#issuecomment-1458198652
We need to install `protoc` in the manylinux container:
> Note that this image is very basic and only contains python, maturin and stable rust. If you need additional tools, you can run commands inside the manylinux container. See [konstin/complex-manylinux-maturin-docker](https://github.com/konstin/complex-manylinux-maturin-docker) for a small educational example or [nanoporetech/fast-ctc-decode](https://github.com/nanoporetech/fast-ctc-decode/blob/b226ea0f2b2f4f474eff47349703d57d2ea4801b/.github/workflows/publish.yml) for a real world setup.
https://www.maturin.rs/index.html#manylinux-and-auditwheel
OR we enable the [`protoc` feature](https://github.com/substrait-io/substrait-rs/blob/main/Cargo.toml#L30) of the substrait crate for these targets to build `protoc` from source in the container.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] cpcloud commented on pull request #247: Fix broken mac win manylinux action
Posted by "cpcloud (via GitHub)" <gi...@apache.org>.
cpcloud commented on PR #247:
URL: https://github.com/apache/arrow-datafusion-python/pull/247#issuecomment-1458159328
@andygrove @iajoiner I don't know what's going on here. Can one of you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] cpcloud commented on a diff in pull request #247: Fix broken mac win manylinux action
Posted by "cpcloud (via GitHub)" <gi...@apache.org>.
cpcloud commented on code in PR #247:
URL: https://github.com/apache/arrow-datafusion-python/pull/247#discussion_r1118981731
##########
.github/workflows/build.yml:
##########
@@ -97,19 +112,25 @@ jobs:
name: python-wheel-license
path: .
- run: cat LICENSE.txt
+ - name: Install Protoc
Review Comment:
Why did you duplicate the protoc install here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] iajoiner commented on a diff in pull request #247: Fix broken mac win manylinux action
Posted by "iajoiner (via GitHub)" <gi...@apache.org>.
iajoiner commented on code in PR #247:
URL: https://github.com/apache/arrow-datafusion-python/pull/247#discussion_r1119005295
##########
.github/workflows/build.yml:
##########
@@ -97,19 +112,25 @@ jobs:
name: python-wheel-license
path: .
- run: cat LICENSE.txt
+ - name: Install Protoc
+ uses: arduino/setup-protoc@v1
+ with:
+ version: '3.x'
+ repo-token: ${{ secrets.GITHUB_TOKEN }}
Review Comment:
@cpcloud Nice catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] iajoiner commented on pull request #247: Fix broken mac win manylinux action
Posted by "iajoiner (via GitHub)" <gi...@apache.org>.
iajoiner commented on PR #247:
URL: https://github.com/apache/arrow-datafusion-python/pull/247#issuecomment-1458242469
@cpcloud @mbrobbel Really thanks! Will do it tonight.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org