You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/03 21:35:13 UTC

[GitHub] [arrow-datafusion] carols10cents opened a new issue #1398: Turn off unused default features of chrono and ahash

carols10cents opened a new issue #1398:
URL: https://github.com/apache/arrow-datafusion/issues/1398


   **Describe the bug**
   
   Some features of chrono and ahash aren't used by datafusion. Disabling them gives projects depending on datafusion more choice in what features to enable.
   
   **Additional context**
   Add any other context about the problem here.
   
   For chrono:
   
   Chrono's default features contain "oldtime", which is deprecated.
   According to [the docs](https://docs.rs/chrono/0.4.19/chrono/#duration),
   
   > new code should disable the oldtime feature and use the
   > chrono::Duration type instead. The oldtime feature is enabled by
   > default for backwards compatibility, but future versions of Chrono
   > are likely to remove the feature entirely.
   
   so follow that recommendation by setting default-features to false. 
   
   It doesn't seem like any of the other features are used.
   
   For ahash:
   
   The default feature set of the ahash crate is ["std"](https://github.com/tkaitchuck/aHash/blob/e77cab8c1e15bfc9f54dfd28bd8820c2a7bb27c4/Cargo.toml#L24-L25). The std feature enables features which require the standard library, namely `AHashMap` and `AHashSet`. DataFusion currently only uses `AHasher`, `CallHasher`, and `RandomState`, none of which require the standard library.
   
   PR incoming!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] Dandandan closed issue #1398: Turn off unused default features of chrono and ahash

Posted by GitBox <gi...@apache.org>.

Dandandan closed issue #1398:
URL: https://github.com/apache/arrow-datafusion/issues/1398


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org