You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/05/14 12:38:47 UTC
[GitHub] [pulsar] lhotari opened a new pull request #10590: [Tests] Fix running of all pulsar-broker tests
lhotari opened a new pull request #10590:
URL: https://github.com/apache/pulsar/pull/10590
Fixes #10589
### Motivation
See #10589 . Tests that don't belong to any TestNG group aren't run at all in pulsar-broker module.
### Modifications
* Add logic to Pulsar's TestNG listener to add a test method to "other" group when no group has been specified.
* Run the "other" group as part of broker_group_2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] linlinnn commented on pull request #10590: [CI] Run pulsar-broker tests that don't belong to any TestNG group
Posted by GitBox <gi...@apache.org>.
linlinnn commented on pull request #10590:
URL: https://github.com/apache/pulsar/pull/10590#issuecomment-841276983
There is a flaky test reported in CI.
```
Error: shouldTerminateWhenFutureIsCancelled(org.apache.pulsar.broker.service.GracefulExecutorServicesShutdownTest) Time elapsed: 0.027 s <<< FAILURE!
java.lang.AssertionError: awaitTermination should have been interrupted expected [true] but found [false]
at org.testng.Assert.fail(Assert.java:99)
at org.testng.Assert.failNotEquals(Assert.java:1037)
at org.testng.Assert.assertTrue(Assert.java:45)
at org.apache.pulsar.broker.service.GracefulExecutorServicesShutdownTest.shouldTerminateWhenFutureIsCancelled(GracefulExecutorServicesShutdownTest.java:154)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:132)
at org.testng.internal.InvokeMethodRunnable.runOne(InvokeMethodRunnable.java:45)
at org.testng.internal.InvokeMethodRunnable.call(InvokeMethodRunnable.java:73)
at org.testng.internal.InvokeMethodRunnable.call(InvokeMethodRunnable.java:11)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base/java.lang.Thread.run(Thread.java:829)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat merged pull request #10590: [CI] Run pulsar-broker tests that don't belong to any TestNG group
Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #10590:
URL: https://github.com/apache/pulsar/pull/10590
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org