You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by ko...@apache.org on 2023/06/26 06:13:12 UTC

[arrow] branch main updated: GH-36239: [CI][C++] Add support for multiple flags for ARROW_*_FLAGS_* (#36281)

This is an automated email from the ASF dual-hosted git repository.

kou pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/main by this push:
     new 1e7f2fd46b GH-36239: [CI][C++] Add support for multiple flags for ARROW_*_FLAGS_* (#36281)
1e7f2fd46b is described below

commit 1e7f2fd46b3cf70c596d477bae892aa323dc07ab
Author: Sutou Kouhei <ko...@clear-code.com>
AuthorDate: Mon Jun 26 15:13:06 2023 +0900

    GH-36239: [CI][C++] Add support for multiple flags for ARROW_*_FLAGS_* (#36281)
    
    ### Rationale for this change
    
    Quoting is needed for multiple flags.
    
    ### What changes are included in this PR?
    
    Add quoting.
    
    ### Are these changes tested?
    
    Yes.
    
    ### Are there any user-facing changes?
    
    No.
    * Closes: #36239
    
    Authored-by: Sutou Kouhei <ko...@clear-code.com>
    Signed-off-by: Sutou Kouhei <ko...@clear-code.com>
---
 ci/scripts/cpp_build.sh | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/ci/scripts/cpp_build.sh b/ci/scripts/cpp_build.sh
index b2dd1631cc..2ef9c0ee22 100755
--- a/ci/scripts/cpp_build.sh
+++ b/ci/scripts/cpp_build.sh
@@ -84,12 +84,12 @@ cmake \
   -DARROW_CSV=${ARROW_CSV:-ON} \
   -DARROW_CUDA=${ARROW_CUDA:-OFF} \
   -DARROW_CXXFLAGS=${ARROW_CXXFLAGS:-} \
-  -DARROW_CXX_FLAGS_DEBUG=${ARROW_CXX_FLAGS_DEBUG:-} \
-  -DARROW_CXX_FLAGS_RELEASE=${ARROW_CXX_FLAGS_RELEASE:-} \
-  -DARROW_CXX_FLAGS_RELWITHDEBINFO=${ARROW_CXX_FLAGS_RELWITHDEBINFO:-} \
-  -DARROW_C_FLAGS_DEBUG=${ARROW_C_FLAGS_DEBUG:-} \
-  -DARROW_C_FLAGS_RELEASE=${ARROW_C_FLAGS_RELEASE:-} \
-  -DARROW_C_FLAGS_RELWITHDEBINFO=${ARROW_C_FLAGS_RELWITHDEBINFO:-} \
+  -DARROW_CXX_FLAGS_DEBUG="${ARROW_CXX_FLAGS_DEBUG:-}" \
+  -DARROW_CXX_FLAGS_RELEASE="${ARROW_CXX_FLAGS_RELEASE:-}" \
+  -DARROW_CXX_FLAGS_RELWITHDEBINFO="${ARROW_CXX_FLAGS_RELWITHDEBINFO:-}" \
+  -DARROW_C_FLAGS_DEBUG="${ARROW_C_FLAGS_DEBUG:-}" \
+  -DARROW_C_FLAGS_RELEASE="${ARROW_C_FLAGS_RELEASE:-}" \
+  -DARROW_C_FLAGS_RELWITHDEBINFO="${ARROW_C_FLAGS_RELWITHDEBINFO:-}" \
   -DARROW_DATASET=${ARROW_DATASET:-ON} \
   -DARROW_DEPENDENCY_SOURCE=${ARROW_DEPENDENCY_SOURCE:-AUTO} \
   -DARROW_ENABLE_TIMING_TESTS=${ARROW_ENABLE_TIMING_TESTS:-ON} \