You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2023/01/04 06:14:12 UTC

[GitHub] [ozone] jojochuang opened a new pull request, #4141: HDDS-7722. Fix TestOMKeyCommitRequest

jojochuang opened a new pull request, #4141:
URL: https://github.com/apache/ozone/pull/4141

   ## What changes were proposed in this pull request?
   
   Fix an incorrect test check
   
   ## What is the link to the Apache JIRA
   
   [HDDS-7722](https://issues.apache.org/jira/browse/HDDS-7722)
   
   ## How was this patch tested?
   
   This is a test-only change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] jojochuang commented on pull request #4141: HDDS-7722. Fix TestOMKeyCommitRequest

Posted by GitBox <gi...@apache.org>.
jojochuang commented on PR #4141:
URL: https://github.com/apache/ozone/pull/4141#issuecomment-1372840229

   I'll close this PR for now and raise a new PR. I'm also reviewing other part of production code looking for bugs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] errose28 commented on pull request #4141: HDDS-7722. Fix TestOMKeyCommitRequest

Posted by GitBox <gi...@apache.org>.
errose28 commented on PR #4141:
URL: https://github.com/apache/ozone/pull/4141#issuecomment-1371348109

   Cause and fix LGTM, can you just fix the CI @jojochuang ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] jojochuang closed pull request #4141: HDDS-7722. Fix TestOMKeyCommitRequest

Posted by GitBox <gi...@apache.org>.
jojochuang closed pull request #4141: HDDS-7722. Fix TestOMKeyCommitRequest
URL: https://github.com/apache/ozone/pull/4141


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] jojochuang commented on pull request #4141: HDDS-7722. Fix TestOMKeyCommitRequest

Posted by GitBox <gi...@apache.org>.
jojochuang commented on PR #4141:
URL: https://github.com/apache/ozone/pull/4141#issuecomment-1372838919

   Hey turns out this is more involved than i thought. There's even a bug in the production FSO code. So not just a trivial test fix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org