You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/06/20 16:28:00 UTC
[jira] [Commented] (TINKERPOP-1989) Preserve order that plugins are
applied in Gremlin Console
[ https://issues.apache.org/jira/browse/TINKERPOP-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518334#comment-16518334 ]
ASF GitHub Bot commented on TINKERPOP-1989:
-------------------------------------------
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/880
TINKERPOP-1989 Enforce order of plugin load in Gremlin Console
https://issues.apache.org/jira/browse/TINKERPOP-1989
Use the order presented in the configuration file to enforce the load order.
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1989
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/880.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #880
----
commit 6c75ceb25d6a828489f29b883be99ae7739e09e0
Author: Stephen Mallette <sp...@...>
Date: 2018-06-20T15:24:34Z
TINKERPOP-1989 Enforce order of plugin load in Gremlin Console
Use the order presented in the configuration file to enforce the load order.
----
> Preserve order that plugins are applied in Gremlin Console
> ----------------------------------------------------------
>
> Key: TINKERPOP-1989
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1989
> Project: TinkerPop
> Issue Type: Improvement
> Components: console
> Affects Versions: 3.2.9
> Reporter: stephen mallette
> Assignee: stephen mallette
> Priority: Minor
> Fix For: 3.4.0, 3.3.4, 3.2.10
>
>
> Plugins are now loaded in the order that {{ServiceLoader}} constructs them. Would be better if the plugins respected the order of the configuration file, that way the user could expect some control there in case one plugin depended on another for some reason. It's not a perfect system as users would be responsible for ordering, but it's a cheap, non-breaking way to at least provide some method for dealing with dependencies.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)