You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by anilkumar gingade <ag...@pivotal.io> on 2015/10/02 01:10:51 UTC
Re: Review Request 37404: GEODE-157: Check for colocation not failing
if non colocated comparison is first comparison made
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37404/#review101289
-----------------------------------------------------------
Ship it!
Ship It!
- anilkumar gingade
On Aug. 12, 2015, 5:59 p.m., Jason Huynh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37404/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2015, 5:59 p.m.)
>
>
> Review request for geode, anilkumar gingade, Bruce Schuchardt, Jianxia Chen, Lynn Gallinat, and Qihong Chen.
>
>
> Repository: geode
>
>
> Description
> -------
>
> There is a bug when checking for co located regions, if the first region being checked happens to be not co located, the logic ignores this and continues onward. This then causes the query to throw an unrelated exception
>
> The order of iterators changes in java 1.8. This will start showing up in a few tests if we go to 1.8. However it should be fixed now as the logic is wrong.
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/cache/query/internal/DefaultQuery.java 3c87d7e
>
> Diff: https://reviews.apache.org/r/37404/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Huynh
>
>