[GitHub] sjanc commented on a change in pull request #622: nimble: Some fixes for scheduling aux tx/rx

[gi...@git.apache.org]

sjanc commented on a change in pull request #622: nimble: Some fixes for scheduling aux tx/rx
URL: https://github.com/apache/mynewt-core/pull/622#discussion_r145131131
 
 

 ##########
 File path: hw/drivers/nimble/nrf52/src/ble_phy.c
 ##########
 @@ -918,12 +918,10 @@ ble_phy_rx_start_isr(void)
     ble_hdr->rxinfo.user_data = NULL;
 #endif
 
-    /*
-     * Calculate receive start time.
-     *
-     * XXX: possibly use other routine with remainder!
-     */
-    usecs = NRF_TIMER0->CC[1] - ble_phy_mode_pdu_start_off(g_ble_phy_data.phy_cur_phy_mode);
+    /* Calculate accurate packets start time (with remainder) */
+    usecs = NRF_TIMER0->CC[1];
+    usecs -= ble_phy_mode_pdu_start_off(ble_hdr->rxinfo.phy_mode);
+    usecs -= g_ble_phy_t_rxaddrdelay[ble_hdr->rxinfo.phy_mode];
 
 Review comment:
   just wondering if this will not wrap around when subtracting.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services