You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2015/09/10 17:01:44 UTC

Review Request 38256: Update framework-rate-limiting.md

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38256/
-----------------------------------------------------------

Review request for mesos and Jiang Yan Xu.


Repository: mesos


Description
-------

The configuration parameter for rate limits should be --rate_limts
but not --rate-limits.


Diffs
-----

  docs/framework-rate-limiting.md cb0bbb707a48657e70ed20f1daf469e28d8d531f 

Diff: https://reviews.apache.org/r/38256/diff/


Testing
-------


Thanks,

Guangya Liu

Re: Review Request 38256: Update framework-rate-limiting.md

Posted by Mesos ReviewBot <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38256/#review98407
-----------------------------------------------------------


Patch looks great!

Reviews applied: [38256]

All tests passed.

- Mesos ReviewBot


On Sept. 10, 2015, 3:01 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38256/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2015, 3:01 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The configuration parameter for rate limits should be --rate_limts
> but not --rate-limits.
> 
> 
> Diffs
> -----
> 
>   docs/framework-rate-limiting.md cb0bbb707a48657e70ed20f1daf469e28d8d531f 
> 
> Diff: https://reviews.apache.org/r/38256/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 38256: Update framework-rate-limiting.md

Posted by Jiang Yan Xu <ya...@jxu.me>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38256/#review98477
-----------------------------------------------------------

Ship it!


Thanks!

- Jiang Yan Xu


On Sept. 10, 2015, 8:01 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38256/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2015, 8:01 a.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The configuration parameter for rate limits should be --rate_limts
> but not --rate-limits.
> 
> 
> Diffs
> -----
> 
>   docs/framework-rate-limiting.md cb0bbb707a48657e70ed20f1daf469e28d8d531f 
> 
> Diff: https://reviews.apache.org/r/38256/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>