[GitHub] [incubator-mxnet] leezu edited a comment on pull request #18749: Refactor Gluon parameter serialization format

[GitBox <gi...@apache.org>]

leezu edited a comment on pull request #18749:
URL: https://github.com/apache/incubator-mxnet/pull/18749#issuecomment-660434713


   There's no code in the backend that interacts with parameters. You can search for "MXNDArrayLoad" and you see that all code invoking this API has been removed. As the backend does not interact with the format, there is no point in adding APIs here, as their use is not yet defined.
   The zipfile and numpy formats are trivial to work with, so there's no issue in adding the support at any time.
   
   > Please add test for backward compatibility
   
   The old format is faulty and I don't see a strong reason to provide backwards compatibility throughout 2.x series. We may remove the C API for loading the old format in a later PR (for example when removing the ndarray operators). As of this PR, backwards compatibility provided as there is no change to C APIs and the Python code backs of to using the C API if the input is not of the new format. It's tested already via unittests and integration tests (via the model-zoo API). Unittest: 
   
   https://github.com/apache/incubator-mxnet/blob/a4ea4a8330251dd244947074cf4ddb875e611dd5/tests/python/unittest/test_ndarray.py#L1988-L2001


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org