[jira] [Commented] (OFBIZ-3883) Customer's Shipment Address Not Assigned to Dropship Purchase Orders

["Paul Foxworthy (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-3883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488411#comment-13488411 ] 

Paul Foxworthy commented on OFBIZ-3883:
---------------------------------------

Hi John,

As you know these methods are overloaded and there is a second form where you specify the shipping group.

I think the current implementation was designed for convenience in the common situation where there is only one shipping group. Your suggested change will change the semantics of the methods.

What do you think about this:

- Introduce new methods with names setAllShippingContactMechId etc, which execute a loop as you've suggested.
- Deprecate the existing setShippingContactMechId etc which only set shipping group zero. Those methods are, as you've observed, dangerous and confusing. The two-parameter forms where a shipping group is specified should be kept as-is, i.e. *not* deprecated.
- Think through the right thing to do for each call to the deprecated methods. They should be changed to call the setAll..., or possibly to the two-parameter form to make clear a change to only one shipping group is intended.
- Eventually we should be able to remove the deprecated methods altogether.

Cheers

Paul Foxworthy

                
> Customer's Shipment Address Not Assigned to Dropship Purchase Orders
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-3883
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3883
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Release Branch 10.04, SVN trunk
>         Environment: demo-trunk.ofbiz.apache.org
>            Reporter: Martin Kreidenweis
>            Assignee: Jacques Le Roux
>         Attachments: Jira-3883-ShoppingCat.java-patch.txt
>
>
> When buying drop ship products from the demo store the customer's shipping address is not saved with the purchase order, so the shipping address cannot be provided to the drop ship supplier. 
> Steps to Reproduce:
> * From the DropShip Category add "DropShip from BigSupplier" and "DropShip from DemoSupplier" to your cart. 
> * Login as admin
> * Use the one page checkout to order the products
> Resulting Order: 
> https://demo-trunk.ofbiz.apache.org:8443/ordermgr/control/orderview?orderId=WSCO10002
> The purchase orders WS10003 and WS10004 are associated correctly with the order items, but as the shipping groups don't have addresses, the purchase orders don't have either.
> Expectation:
> All Shipment groups should have the shipping address assigned.
> Actual:
> Only the first shipment group has the shipping address assigned. 
> Possibly offending line of Code: 
> ShoppingCart.java line 2235:
>         this.setShippingContactMechId(0, shippingContactMechId);
> Should probably not add the contactMechId only to the first CartShipInfo. When we tried to change that, though, drop shipping broke somehow completely. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira